alex/yomichan
1
Fork 0
Code Releases Activity

Fix text being overwritten when generating the query parser content (#1483)

Browse Source
This commit is contained in:
toasted-nutbread 2021-03-03 18:06:12 -05:00 committed by GitHub
parent 14717b7579
commit ca4d5a2ac1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ext/js/display/query-parser.js
View File

@ -149,7 +149,7 @@ class QueryParser extends EventDispatcher {
this._queryParser.textContent = ''; this._queryParser.textContent = '';
this._queryParser.dataset.parsed = 'true'; this._queryParser.dataset.parsed = 'true';
if (!parseResult) { return; } if (!parseResult) { return; }
this._queryParser.appendChild(this._createParseResult(parseResult.content, false)); this._queryParser.appendChild(this._createParseResult(parseResult.content));
} }
_updateParserModeSelect(select, parseResults, selectedParser) { _updateParserModeSelect(select, parseResults, selectedParser) {
@ -191,7 +191,7 @@ class QueryParser extends EventDispatcher {
termNode.className = 'query-parser-term'; termNode.className = 'query-parser-term';
for (const segment of term) { for (const segment of term) {
if (segment.reading.trim().length === 0) { if (segment.reading.trim().length === 0) {
this._addSegmentText(segment.text, termNode); termNode.appendChild(document.createTextNode(segment.text));
} else { } else {
termNode.appendChild(this._createSegment(segment)); termNode.appendChild(this._createSegment(segment));
} }
@ -214,13 +214,9 @@ class QueryParser extends EventDispatcher {
segmentNode.appendChild(textNode); segmentNode.appendChild(textNode);
segmentNode.appendChild(readingNode); segmentNode.appendChild(readingNode);
this._addSegmentText(segment.text, textNode); textNode.textContent = segment.text;
readingNode.textContent = segment.reading; readingNode.textContent = segment.reading;
return segmentNode; return segmentNode;
} }
_addSegmentText(text, container) {
container.textContent = text;
}
} }