From ca4d5a2ac19d1e97025b579157568fb1e9fa0701 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Wed, 3 Mar 2021 18:06:12 -0500 Subject: [PATCH] Fix text being overwritten when generating the query parser content (#1483) --- ext/js/display/query-parser.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/ext/js/display/query-parser.js b/ext/js/display/query-parser.js index c21033de..8c5ce331 100644 --- a/ext/js/display/query-parser.js +++ b/ext/js/display/query-parser.js @@ -149,7 +149,7 @@ class QueryParser extends EventDispatcher { this._queryParser.textContent = ''; this._queryParser.dataset.parsed = 'true'; if (!parseResult) { return; } - this._queryParser.appendChild(this._createParseResult(parseResult.content, false)); + this._queryParser.appendChild(this._createParseResult(parseResult.content)); } _updateParserModeSelect(select, parseResults, selectedParser) { @@ -191,7 +191,7 @@ class QueryParser extends EventDispatcher { termNode.className = 'query-parser-term'; for (const segment of term) { if (segment.reading.trim().length === 0) { - this._addSegmentText(segment.text, termNode); + termNode.appendChild(document.createTextNode(segment.text)); } else { termNode.appendChild(this._createSegment(segment)); } @@ -214,13 +214,9 @@ class QueryParser extends EventDispatcher { segmentNode.appendChild(textNode); segmentNode.appendChild(readingNode); - this._addSegmentText(segment.text, textNode); + textNode.textContent = segment.text; readingNode.textContent = segment.reading; return segmentNode; } - - _addSegmentText(text, container) { - container.textContent = text; - } }