alex/yomichan
1
Fork 0
Code Releases Activity

Change popupActionBarLocation to top (#1222)

Browse Source
This commit is contained in:
toasted-nutbread 2021-01-10 16:49:40 -05:00 committed by GitHub
parent 7f07b905ab
commit 25080ac82e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ext/bg/data/options-schema.json
View File

@ -283,7 +283,7 @@
"popupActionBarLocation": { "popupActionBarLocation": {
"type": "string", "type": "string",
"enum": ["left", "right", "top", "bottom"], "enum": ["left", "right", "top", "bottom"],
"default": "right" "default": "top"
} }
} }
}, },

2
ext/bg/js/options.js
View File

@ -686,6 +686,7 @@ class OptionsUtil {
// Moved anki.sentenceExt to sentenceParsing.scanExtent. // Moved anki.sentenceExt to sentenceParsing.scanExtent.
// Added sentenceParsing.enableTerminationCharacters. // Added sentenceParsing.enableTerminationCharacters.
// Added sentenceParsing.terminationCharacters. // Added sentenceParsing.terminationCharacters.
// Changed general.popupActionBarLocation.
for (const profile of options.profiles) { for (const profile of options.profiles) {
profile.options.translation.textReplacements = { profile.options.translation.textReplacements = {
searchOriginal: true, searchOriginal: true,
@ -710,6 +711,7 @@ class OptionsUtil {
] ]
}; };
delete profile.options.anki.sentenceExt; delete profile.options.anki.sentenceExt;
profile.options.general.popupActionBarLocation = 'top';
} }
return options; return options;
} }

2
test/test-options-util.js
View File

@ -296,7 +296,7 @@ function createProfileOptionsUpdatedTestData1() {
maximumClipboardSearchLength: 1000, maximumClipboardSearchLength: 1000,
popupCurrentIndicatorMode: 'triangle', popupCurrentIndicatorMode: 'triangle',
popupActionBarVisibility: 'auto', popupActionBarVisibility: 'auto',
popupActionBarLocation: 'right' popupActionBarLocation: 'top'
}, },
audio: { audio: {
enabled: true, enabled: true,