From 25080ac82eef83fdaa921e2a8b12261130b8ac85 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Sun, 10 Jan 2021 16:49:40 -0500 Subject: [PATCH] Change popupActionBarLocation to top (#1222) --- ext/bg/data/options-schema.json | 2 +- ext/bg/js/options.js | 2 ++ test/test-options-util.js | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ext/bg/data/options-schema.json b/ext/bg/data/options-schema.json index 151a7fe3..5d23df02 100644 --- a/ext/bg/data/options-schema.json +++ b/ext/bg/data/options-schema.json @@ -283,7 +283,7 @@ "popupActionBarLocation": { "type": "string", "enum": ["left", "right", "top", "bottom"], - "default": "right" + "default": "top" } } }, diff --git a/ext/bg/js/options.js b/ext/bg/js/options.js index 6c335346..86f76698 100644 --- a/ext/bg/js/options.js +++ b/ext/bg/js/options.js @@ -686,6 +686,7 @@ class OptionsUtil { // Moved anki.sentenceExt to sentenceParsing.scanExtent. // Added sentenceParsing.enableTerminationCharacters. // Added sentenceParsing.terminationCharacters. + // Changed general.popupActionBarLocation. for (const profile of options.profiles) { profile.options.translation.textReplacements = { searchOriginal: true, @@ -710,6 +711,7 @@ class OptionsUtil { ] }; delete profile.options.anki.sentenceExt; + profile.options.general.popupActionBarLocation = 'top'; } return options; } diff --git a/test/test-options-util.js b/test/test-options-util.js index 5ce9313e..c4a6addd 100644 --- a/test/test-options-util.js +++ b/test/test-options-util.js @@ -296,7 +296,7 @@ function createProfileOptionsUpdatedTestData1() { maximumClipboardSearchLength: 1000, popupCurrentIndicatorMode: 'triangle', popupActionBarVisibility: 'auto', - popupActionBarLocation: 'right' + popupActionBarLocation: 'top' }, audio: { enabled: true,