Commit Graph

1447 Commits

Author SHA1 Message Date
toasted-nutbread
d9b4404075 Create functions for the cases of isMouseButton
jshint was showing a warning that there was no break statement
after the first case, which there doesn't need to be.

The most straightforward way to fix this without using the unclear
// jshint ignore:line
is to just have two functions.

This change also updates invocations of isMouseButton to use
the exact case function, as this will remove the need to check
the case of mosueEvent.type. This was done because onMouseMove
is invoked at a high frequency.
2019-11-10 14:00:44 -05:00
toasted-nutbread
dad685dba4 Fix overwriting const value 2019-11-10 13:56:06 -05:00
toasted-nutbread
d6cdd693c8 Fix several warnings about name conflicts 2019-11-10 13:55:37 -05:00
toasted-nutbread
157e6f7c75 Optimize DisplaySearch.onKeyDown 2019-11-10 13:40:48 -05:00
toasted-nutbread
120f97be26 Refactor apiOptionsSet 2019-11-10 13:36:35 -05:00
toasted-nutbread
aa92855b37 Fixes for Edge 2019-11-10 13:01:39 -05:00
toasted-nutbread
75883ed885 Remove dexie 2019-11-10 13:01:39 -05:00
toasted-nutbread
e48bfb8f1a Use native indexedDB pointer 2019-11-10 13:01:39 -05:00
toasted-nutbread
183ec6b381 Use native IndexedDB to delete the database 2019-11-10 13:01:39 -05:00
toasted-nutbread
3a1e3392ed Use native IndexedDB to create database and object stores 2019-11-10 13:01:39 -05:00
toasted-nutbread
6c023789d9 Use native IndexedDB for bulkAdd operations 2019-11-10 13:01:39 -05:00
toasted-nutbread
750439ebf0 Use native IndexedDB for database additions 2019-11-10 13:01:39 -05:00
toasted-nutbread
6f53030469 Use for of loop instead of forEach 2019-11-10 12:25:28 -05:00
sabs
fd17a0fccd Remove Download check when resolving Audio data
There is a bug (seemingly unreported) in Yomichan where an Anki card
will not contain any audio if the JapanesePod101 audio source trumps
a secondary audio source (e.g. JapanesePod101-alternate) where
the jpod101 source can't find the word requested.

For example, そして has an audio entry in the alternate source but not
the standard source.

(Alternatively, there may be a bug in the jpod101 audioUrlBuilder,
because I've only noticed this problem with hiragana-only expressions.
JPod101 may not host those on the same url scheme any more.  I'm not
sure how to fix that, though, and the bug I'm addressing here does
still persist).

The reason this happens is that audioGetFromUrl uses downloaded audio
to effectively check for a 404 (by examining the audio duration), but
that check doesn't happen when an Anki card is being created (i.e.
"download" is set, which I've changed to "willDownload" here).

This change removes that check, but retains the will-download intent
information to prevent attempts to download tts data, which AnkiConnect
cannot do. I've also added a short explanation as to why the download
check happens where it does.

I think the unused audio object will get garbage collected since it's
not referenced again, but I've explicitly unset it as well.
2019-11-09 20:58:09 -05:00
toasted-nutbread
3e864c44c3 Fixes for Edge 2019-11-09 20:52:16 -05:00
siikamiika
4ac4128388 search page checkbox styling
Change checkboxes to color-inverting icons
2019-11-10 03:15:55 +02:00
toasted-nutbread
184cc4cf28 Allow templates to be tested on the settings page 2019-11-09 16:34:39 -05:00
toasted-nutbread
085881d342 Use HTML templates for anki fields 2019-11-09 14:31:13 -05:00
siikamiika
40c8268fd6 always disable scanning IME checkbox label 2019-11-09 13:01:21 +02:00
siikamiika
cf0bb0a9e2 enable custom CSS on search page 2019-11-09 12:43:22 +02:00
siikamiika
177fad56b5 use scan toggling for stroke order diagram too 2019-11-09 12:28:12 +02:00
siikamiika
25af532ab7 enable expression scan toggling on search page 2019-11-09 12:27:09 +02:00
toasted-nutbread
b59a5b8cdb Add support for some regex functions in handlebars templates 2019-11-08 22:57:20 -05:00
toasted-nutbread
4d7940e8e4 Optimize dictFieldFormat 2019-11-08 22:25:03 -05:00
toasted-nutbread
fa963722a7 Fix seekForward and seekBackward not handling length=0 case correctly 2019-11-08 19:24:33 -05:00
toasted-nutbread
b059609670 Add outdated warning 2019-11-07 20:30:55 -05:00
toasted-nutbread
cad0648cbe Remove unused function 2019-11-07 20:30:55 -05:00
toasted-nutbread
f7700789fe Update dictionary order based on priority 2019-11-07 20:30:55 -05:00
toasted-nutbread
fcb922400a Prevent page exit while database operations are in progress 2019-11-07 20:30:55 -05:00
toasted-nutbread
e5dcb41824 Add support for importing multiple dictionaries at once 2019-11-07 20:30:55 -05:00
toasted-nutbread
e091c7ebe2 Add support for deleting individual dictionaries 2019-11-07 20:30:55 -05:00
toasted-nutbread
e355b83914 Update how nodes are hidden 2019-11-07 20:30:55 -05:00
toasted-nutbread
3d78d5400d Add button and confirmation dialog for database purge 2019-11-07 20:30:55 -05:00
toasted-nutbread
2ab871e7ee Update how dictionaries are displayed on the settings page 2019-11-07 20:30:55 -05:00
toasted-nutbread
79069d5908 Add functions for getting dictionary information 2019-11-07 20:30:55 -05:00
toasted-nutbread
44638b7ceb Simplify how option visibility is changed 2019-11-07 20:30:55 -05:00
91c01e0a7e Update version 2019-11-05 19:03:23 -08:00
toasted-nutbread
a85ec440d6 Fix overlapping popup timers 2019-11-05 19:48:08 -05:00
siikamiika
83460bcdad refactoring and optimization 2019-11-04 02:15:33 +02:00
siikamiika
f4a987912a prevent accidental lookup on glossary text select 2019-11-03 18:56:22 +02:00
toasted-nutbread
75ff05148d Fix autoHideResults not working 2019-11-03 11:06:31 -05:00
toasted-nutbread
7de24dd355 Add favicons 2019-11-02 10:10:03 -04:00
toasted-nutbread
bcffe80a1e Group similar functions together 2019-10-28 17:03:42 -04:00
toasted-nutbread
6d85dae68d Fix some issues with the context menu 2019-10-28 17:03:42 -04:00
toasted-nutbread
d2644c0776 Style update 2019-10-28 17:03:42 -04:00
toasted-nutbread
c365101ec2 Reset preventions earlier 2019-10-28 17:03:42 -04:00
toasted-nutbread
e542f38110 Check pendingLookup earlier 2019-10-28 17:03:42 -04:00
toasted-nutbread
9703e123bf Remove setPrimaryTouch 2019-10-28 17:03:42 -04:00
toasted-nutbread
80eb357527 Simplify touch event implementation 2019-10-28 17:03:42 -04:00
toasted-nutbread
131dc8397d Make selectionContainsPoint static 2019-10-28 17:03:42 -04:00
toasted-nutbread
a648e05091 Improve naming 2019-10-28 17:03:42 -04:00
toasted-nutbread
9178636613 Remove setters 2019-10-28 17:03:42 -04:00
toasted-nutbread
c74c466c36 Remove unused variable 2019-10-28 17:03:42 -04:00
toasted-nutbread
f2dec4ca20 Remove searchFromTouch 2019-10-28 17:03:42 -04:00
toasted-nutbread
8c5240d7a6 Simplify how touch events use onAfterSearch 2019-10-28 17:03:42 -04:00
toasted-nutbread
e91bcf5f55 Rename textSourceLast to textSourceCurrent 2019-10-28 17:03:42 -04:00
toasted-nutbread
be27781c15 Update how definitions are searched for 2019-10-28 17:03:42 -04:00
toasted-nutbread
f927f806ba Move check 2019-10-28 17:03:42 -04:00
toasted-nutbread
1f0a434e96 Remove unused vars 2019-10-28 17:03:42 -04:00
toasted-nutbread
dcb6f68826 Don't pass null textSource into searchSource 2019-10-28 17:03:42 -04:00
toasted-nutbread
185963899b Use promiseTimeout 2019-10-28 17:03:42 -04:00
toasted-nutbread
d608657495 Move onError catch into searchAt 2019-10-28 17:03:42 -04:00
toasted-nutbread
1039536cfb Create promise version of setTimeout 2019-10-28 17:03:42 -04:00
siikamiika
f6d3f739a8 improve search page checkbox usability
Disable text selection and make the entire area clickable, including
whitespace
2019-10-28 01:13:05 +02:00
siikamiika
a31ee0a0e9 refactoring 2019-10-28 00:09:36 +02:00
siikamiika
d62d04f806 fix wanakana toggle on empty input 2019-10-27 23:52:16 +02:00
siikamiika
68179607b3 use apiOptionsGet to modify the correct profile 2019-10-27 23:34:50 +02:00
siikamiika
9641747ba1 Revert "modify correct profile apiOptionsSet"
This reverts commit 51c35c9f30.
2019-10-27 23:02:41 +02:00
siikamiika
51c35c9f30 modify correct profile apiOptionsSet 2019-10-27 22:43:20 +02:00
siikamiika
70418202cf make search page checkbox options persist 2019-10-27 20:11:23 +02:00
siikamiika
48776145d6 add workaround to Chrome clipboard.readText
For some reason this doesn't work on Firefox, so keep using the new API
for Firefox
2019-10-27 15:46:27 +02:00
siikamiika
d3f51690f8 make clipboardRead an optional permission 2019-10-27 01:51:18 +03:00
siikamiika
7ee87265cd refactor and tune wanakana toggling 2019-10-27 01:26:17 +03:00
siikamiika
01ffb052e6 simplify search history state handling 2019-10-26 19:32:41 +03:00
siikamiika
bbbd23c842 add button to enable/disable wanakana IME 2019-10-26 19:12:13 +03:00
siikamiika
303205dc12 keep url query in history 2019-10-26 18:42:57 +03:00
siikamiika
704864b7b2 add clipboard monitor to search page
Related to issue #262 about APIs
2019-10-26 18:15:28 +03:00
siikamiika
bebd70b4e2 remember search history 2019-10-26 16:39:43 +03:00
siikamiika
50769feea7 ignore more keys on search page 2019-10-26 15:15:12 +03:00
siikamiika
9132814ccf focus and scroll to input only when it's needed 2019-10-26 14:30:36 +03:00
siikamiika
fe8eb76928 tweak ignored keys on search page 2019-10-26 03:39:08 +03:00
siikamiika
3a70346eb3 fix various unwanted focus issues on search page
Don't focus input if a modifier or specific keys are pressed
2019-10-26 03:26:24 +03:00
siikamiika
a716a52cab make non-hotkey keys focus input on search page
The issue was that scanning on search page introduced a way to lose
focus of the query input, and the new feature that the search page
hotkey focuses an existing search page instead of opening a new one made
it more obvious.

Now every key that isn't a hotkey focuses the query input, and typing
text into the box scrolls it into view in case it wasn't there when
searching.

There is an accessibility issue that this can cause, because now tab
also focuses the query input before it focuses the next element. I
didn't implement a workaround for that because it would have been more
complicated than this simple fix.

Fixes #263
2019-10-26 01:26:56 +03:00
Danny
aeac7bf2a8
Proper spacing for Anki in {furigana-plain}
This should fix #264 

Note it does not address broken segmentation, just representation
within Anki itself to work properly.
2019-10-23 07:46:43 -04:00
toasted-nutbread
7a3315d75d Use chrome.runtime.getURL instead of chrome.extension.getURL 2019-10-22 20:23:03 -04:00
d32fd1381b increment version for testing 2019-10-20 11:22:50 -07:00
Alex Yatskov
d8f9c2e1d4
Merge pull request #261 from toasted-nutbread/search-button-reuse-tab
Reuse open search tab when clicking search button
2019-10-20 11:06:23 -07:00
Alex Yatskov
6592323855
Merge pull request #259 from toasted-nutbread/database-optimizations2
Database optimizations part 2
2019-10-20 11:04:17 -07:00
toasted-nutbread
362a1ed9e4 Catch exception thrown on Edge 2019-10-20 10:58:22 -04:00
toasted-nutbread
d7dc8ac9cd Add tooltip about middle click behaviour 2019-10-20 10:30:44 -04:00
toasted-nutbread
ce92591b63 Fix window focus not always working 2019-10-19 22:55:32 -04:00
toasted-nutbread
7abc7fd0e7 Use links instead of buttons on context page 2019-10-19 22:54:58 -04:00
toasted-nutbread
205498ef3b Validate chrome.windows exists before usage 2019-10-19 22:45:29 -04:00
toasted-nutbread
ffb6ff9325 Allow multiple options pages to be opened on middle click 2019-10-19 22:34:47 -04:00
toasted-nutbread
d9ae34821c Add support for middle clicks opening new tabs on the context buttons 2019-10-19 22:30:16 -04:00
toasted-nutbread
dbec4bffda Make the search button reuse an open search tab if it exists 2019-10-19 22:28:23 -04:00
Alex Yatskov
03c72e9429
Merge pull request #256 from toasted-nutbread/unlimited-storage
Add unlimited storage permission
2019-10-19 12:01:54 -07:00
toasted-nutbread
eea95eb130 Simplify score to term frequency conversion 2019-10-19 14:18:57 -04:00
toasted-nutbread
96e4bf1735 Use native IndexedDB APIs for findTagForTitle 2019-10-19 13:41:18 -04:00
toasted-nutbread
610c2b9cca Move tagCache out of Database and into Translator 2019-10-19 13:32:05 -04:00