Commit Graph

1510 Commits

Author SHA1 Message Date
Alex Yatskov
e4fa658295
Merge pull request #212 from toasted-nutbread/frontend-cleanup
Frontend cleanup
2019-09-15 11:33:48 -07:00
Alex Yatskov
4af9fc2b3b
Merge pull request #214 from toasted-nutbread/add-anchor-noopener
URL improvements
2019-09-15 11:32:48 -07:00
Alex Yatskov
88a6128e39
Merge pull request #211 from toasted-nutbread/validate-content-window
Validate contentWindow before focus
2019-09-14 17:31:23 -07:00
Alex Yatskov
2add068ff2
Merge pull request #210 from toasted-nutbread/defer-port-creation
Defer creation of communication port until required
2019-09-14 17:30:52 -07:00
Alex Yatskov
ab2db771ad
Merge pull request #208 from toasted-nutbread/fix-popup-orphans
Fix nested popups being shown if parent is hidden
2019-09-14 17:29:52 -07:00
toasted-nutbread
f8aa926f8a Upgrade website URLs to https 2019-09-14 20:18:03 -04:00
toasted-nutbread
ba1875c56a Add rel="noopener" to all anchors with target="_blank" 2019-09-14 19:59:45 -04:00
toasted-nutbread
6358b655ae Isolate options objects created via settings.js
Prevents dead objects created by different windows.
2019-09-14 16:21:41 -04:00
toasted-nutbread
0067dfeacc Remove redundant call of popupTimerClear
Also use explicit null checks rather than truthy checks.
2019-09-14 15:29:43 -04:00
toasted-nutbread
8b1e4d1c6f Return only single element when deepDomScan is not enabled 2019-09-14 14:52:03 -04:00
toasted-nutbread
7dddcb8dca Rename type to cause 2019-09-14 14:31:21 -04:00
toasted-nutbread
6d3037f3d6 Remove destructuring from searchAt, containsPoint, docRangeFromPoint 2019-09-14 14:27:25 -04:00
toasted-nutbread
89941d404c Remove unused variable 2019-09-14 14:11:25 -04:00
toasted-nutbread
721248c821 Remove mouseDownLeft and mouseDownMiddle
MouseEvent.buttons can be used instead.
2019-09-14 14:11:06 -04:00
toasted-nutbread
964de775df Validate contentWindow before focus 2019-09-14 12:02:31 -04:00
toasted-nutbread
304064dae0 Defer creation of communication port until required 2019-09-14 11:58:22 -04:00
toasted-nutbread
bab6a13bfb Fix nested popups being shown if parent is hidden 2019-09-13 18:12:51 -04:00
Alex Yatskov
ec816e6767
Merge pull request #207 from toasted-nutbread/popup-proxy-writing-mode
Add writingMode to PopupProxy* termsShow and kanjiShow
2019-09-12 19:48:22 -07:00
Alex Yatskov
60b32a4a1a
Merge pull request #206 from toasted-nutbread/fix-incorrect-function-name
Replace profileCreateDefaultFieldTemplates with optionsFieldTemplates
2019-09-12 19:47:52 -07:00
Alex Yatskov
1fea1184bd
Merge pull request #205 from toasted-nutbread/settings-improvements2
Settings improvements part 2
2019-09-12 19:47:37 -07:00
toasted-nutbread
76aa30ceba Add writingMode to PopupProxy* termsShow and kanjiShow 2019-09-11 21:29:08 -04:00
toasted-nutbread
c38c7fbda1 Replace profileCreateDefaultFieldTemplates with optionsFieldTemplates 2019-09-11 19:56:13 -04:00
toasted-nutbread
84bd9ff93b Update settings if a different source triggers optionsUpdate 2019-09-10 21:58:53 -04:00
toasted-nutbread
71b700cd22 Add checkbox for options.general.enable 2019-09-10 21:45:43 -04:00
toasted-nutbread
87e513dd77 Fix options reference being changed 2019-09-10 21:44:32 -04:00
toasted-nutbread
1f8c7358cb Create function for setting up form event listeners 2019-09-10 21:43:52 -04:00
toasted-nutbread
36b39e2f65 Create formWrite function 2019-09-10 21:43:51 -04:00
toasted-nutbread
cab39e89c9 Create section for Popup Content Scanning Options 2019-09-10 21:43:51 -04:00
toasted-nutbread
c4e6d7e3d1 Add utility method for checking if a value is a standard object 2019-09-10 20:09:33 -04:00
toasted-nutbread
05ce350792 Use apiOptionsSave instead of optionsSave 2019-09-10 20:09:33 -04:00
toasted-nutbread
4686a31a0a Use apiOptionsGet instead of optionsLoad 2019-09-10 20:09:33 -04:00
toasted-nutbread
99cec1d23f Change how formRead works
The function now modifies values in-place.
2019-09-10 20:09:33 -04:00
toasted-nutbread
8175f80183 Remove calls to apiOptionsGetSync
Use apiOptionsGet everywhere to ensure options is initialized.
2019-09-10 20:09:33 -04:00
toasted-nutbread
1b2a1e50eb Add getOptions function to backend 2019-09-10 20:09:33 -04:00
toasted-nutbread
bc8793eb56 Add a context object for all calls to fetch options 2019-09-10 20:09:33 -04:00
toasted-nutbread
99ca60d4c1 Ensure both Popup and PopupProxy have valid depth 2019-09-10 20:09:33 -04:00
toasted-nutbread
aae971a09e Pass options directly to translator.findTerms* 2019-09-10 20:09:33 -04:00
toasted-nutbread
91bc31d758 Change how options updates are handled on the frontend
Only an 'optionsUpdate' signal is now sent to the frontend with empty data. The frontend then responds by performing apiOptionsGet to update the options. This makes it so that there is only a single function which is responsible for requesting options from the backend.
2019-09-10 20:09:33 -04:00
Alex Yatskov
cc53510883
Merge pull request #204 from toasted-nutbread/settings-improvements
Settings improvements
2019-09-08 19:34:39 -07:00
toasted-nutbread
eb98dfb1a8 Simplify logic for how option updates are propagated 2019-09-06 21:23:35 -04:00
toasted-nutbread
7db2c66105 Use consistent structure for params 2019-09-06 21:23:35 -04:00
toasted-nutbread
13b184707b Remove unnecessary functions
apiOptionsSet not required in bg/js/api.js after optionsSave; optionsSave already invokes apiOptionsSet.
apiOptionsSet not required in fg/js/api.js since it's never invoked by the foreground.
optionsSet handler not required in bg/js/backend.js since the message is never sent by the foreground.
2019-09-06 21:23:35 -04:00
toasted-nutbread
35ca0f35dd Create common function for utilBackend().options 2019-09-06 21:23:35 -04:00
toasted-nutbread
a74cdbff1d Change update process 2019-09-06 19:55:58 -04:00
c53263158b version bump 2019-09-05 20:20:23 -07:00
Alex Yatskov
155986db46
Merge pull request #201 from toasted-nutbread/omit-contains-point-check
Omit containsPoint check on searchAt
2019-09-05 19:46:43 -07:00
Alex Yatskov
6dc44e3f33
Merge pull request #202 from toasted-nutbread/temporary-object-optimization
Temporary object optimization
2019-09-05 19:46:14 -07:00
toasted-nutbread
5ddbb0373f Add function to create default options 2019-09-05 20:57:52 -04:00
toasted-nutbread
ec110fa1b7 Add some validation to options loading 2019-09-05 20:57:52 -04:00
toasted-nutbread
1c767711bb Prevent infinite loops for corrupt options 2019-09-05 20:57:52 -04:00