Commit Graph

1445 Commits

Author SHA1 Message Date
toasted-nutbread
4446cbeabb Create getMergedSecondarySearchResults 2019-10-19 12:28:33 -04:00
toasted-nutbread
96f37fd9dc Create function for body of findTermsMerged's sequencedDefinitions loop 2019-10-19 12:16:38 -04:00
toasted-nutbread
a08cbebeb3 Use findTermsBySequenceBulk instead of findTermsBySequence 2019-10-19 11:34:12 -04:00
toasted-nutbread
a25167df73 Use findKanjiBulk and findKanjiMetaBulk in Translator.findKanji 2019-10-19 10:39:08 -04:00
toasted-nutbread
d212d0aba1 Add additional database bulk methods 2019-10-19 10:19:12 -04:00
toasted-nutbread
9364a7cb4e Create function for creating kanji data and meta 2019-10-18 23:16:33 -04:00
toasted-nutbread
6743b785c9 Remove temp createResult 2019-10-18 23:09:00 -04:00
toasted-nutbread
31ae00d0d3 Add missing validate calls 2019-10-18 23:04:06 -04:00
toasted-nutbread
127a728675 Remove unused functions 2019-10-18 21:58:28 -04:00
toasted-nutbread
a5d7de8e97 Add correction to offset of imposter rect
Necessary when dealing with CSS transforms
2019-10-17 19:30:54 -04:00
toasted-nutbread
8f918c63dc Reposition popup on window resize rather than clear the search
Fixes #107
2019-10-17 18:40:43 -04:00
toasted-nutbread
598cd32946 Update *show* APIs to unified showContent and setContent 2019-10-17 18:40:43 -04:00
toasted-nutbread
779b4af590 Change -teoru endings to be godan verbs 2019-10-16 19:11:45 -04:00
siikamiika
5b98f3ea6e add missing return to fix vertical text mode 2019-10-16 23:49:40 +03:00
toasted-nutbread
16521fec93 Assign first popup on the search page as a depth of 1 2019-10-15 20:23:25 -04:00
toasted-nutbread
173a474d5b Add unlimited storage permission 2019-10-15 19:41:39 -04:00
toasted-nutbread
099909287f Show warning messages if persistant storage fails
Only Firefox seems to support persistent storage properly.
2019-10-15 19:22:30 -04:00
toasted-nutbread
4443ad370e Catch error when trying to persist storage
This happens on Firefox Mobile
2019-10-13 18:41:16 -04:00
toasted-nutbread
693ffebbf7 Make the Options link the first link
Better reflects importance in a top-down list.
2019-10-13 18:38:17 -04:00
toasted-nutbread
437fe4e62e Move anki warnings under anki-general 2019-10-13 18:30:44 -04:00
toasted-nutbread
d42a07dc0b Improve layout of context.html on Firefox Mobile 2019-10-13 18:23:59 -04:00
toasted-nutbread
ba27ea2c9d Center align context popup window buttons 2019-10-13 17:40:51 -04:00
toasted-nutbread
17e2f825f4 Add warning message for Mac users about App Nap 2019-10-13 17:32:28 -04:00
toasted-nutbread
cb236a7430 Add apiGetEnvironmentInfo function 2019-10-13 17:20:55 -04:00
toasted-nutbread
c92fc11fcd Fix getElementWritingMode returning deprecated values on Edge 2019-10-13 16:44:13 -04:00
toasted-nutbread
4f8c84d524 Fix Japanese voice ordering on Firefox for Android 2019-10-13 16:30:31 -04:00
toasted-nutbread
f8e666b70c Fix backend handling errors incorrectly 2019-10-13 16:08:15 -04:00
siikamiika
f3ab7673f9 add css class for dictionary name
Can be used for dictionary specific styling
2019-10-13 21:50:29 +03:00
toasted-nutbread
7bae3824e7 Add support for text-to-speech playback 2019-10-13 12:21:19 -04:00
toasted-nutbread
69b28571bd audioBuildUrl => audioGetUrl and simplify 2019-10-13 12:20:56 -04:00
toasted-nutbread
54d4c65854 Rename audioGetFromSources's createAudioObject argument to download 2019-10-13 12:20:56 -04:00
toasted-nutbread
21a2730cde Add option for text-to-speech 2019-10-13 12:20:56 -04:00
toasted-nutbread
1b96e69ea2 Placeholder and improve consistency of stylesheet rule priorities 2019-10-13 12:12:52 -04:00
toasted-nutbread
b34ff7ebe9 Change #yomichan-float to .yomichan-float
Since there can be more than one popup, using a class makes more sense than an ID.
2019-10-13 12:12:52 -04:00
toasted-nutbread
42d67249c9 Update the popup preview to show live updates to outer CSS changes 2019-10-13 12:12:52 -04:00
toasted-nutbread
c9158a37b5 Allow outer popup stylesheets to be injected 2019-10-13 12:12:51 -04:00
toasted-nutbread
3272948284 Adds setting for controlling the outer style of the popup 2019-10-13 12:12:51 -04:00
toasted-nutbread
118f200500 Simplified how the auto theme works 2019-10-13 12:12:51 -04:00
toasted-nutbread
57db18c31b Leave default stylesheet enabled by default 2019-10-12 19:00:24 -04:00
toasted-nutbread
b086fca69f Add separate theme option for outer popup style 2019-10-12 19:00:24 -04:00
toasted-nutbread
1da60aae2d Update live preview custom CSS on input event 2019-10-12 19:00:24 -04:00
toasted-nutbread
883226b045 Update how custom CSS is applied 2019-10-12 19:00:24 -04:00
toasted-nutbread
c90bc75eb8 Create themes 2019-10-12 19:00:24 -04:00
toasted-nutbread
ceaeeb32dd Remove bootstrap styles from float.html 2019-10-12 19:00:21 -04:00
toasted-nutbread
696ea80e06 Add option for popup theme 2019-10-12 15:44:35 -04:00
toasted-nutbread
be7fa57d5c Add support for a popup preview 2019-10-12 15:44:32 -04:00
toasted-nutbread
537d2ef532 Remove Display.dependencies 2019-10-12 15:31:29 -04:00
toasted-nutbread
6da7683552 Don't pass options around for calls to termsShow, kanjiShow, etc. 2019-10-12 15:31:29 -04:00
toasted-nutbread
a5b208fb89 Check if objects are properly initialized before showing content 2019-10-12 15:31:29 -04:00
toasted-nutbread
8a1637f6b3 Remove .show popup proxy API since it's not used 2019-10-12 15:31:29 -04:00
toasted-nutbread
194615ef21 Make popups store options 2019-10-12 15:31:29 -04:00
toasted-nutbread
3e249e19ac Update Display initialization process 2019-10-12 15:31:29 -04:00
toasted-nutbread
89a8494208 Add function for (de)activating event listeners in Display 2019-10-12 11:25:24 -04:00
toasted-nutbread
cc72514ce6 Frontend updates 2019-10-11 23:24:51 -04:00
toasted-nutbread
a6903d68a4 Revert default audio source behaviour
This more closely matches the upgrade process
2019-10-11 23:24:51 -04:00
toasted-nutbread
70bceb5b56 Improve display of storage stats 2019-10-11 19:48:43 -04:00
toasted-nutbread
6014fe5344 Add support for persistent storage 2019-10-11 19:44:13 -04:00
toasted-nutbread
2bfc7e3972 Fix order of {screenshot} tag 2019-10-11 19:44:13 -04:00
55b2c1d8f5 version bump 2019-10-10 19:49:05 -07:00
toasted-nutbread
6208d6c93b Add UI for editing audio playback sources 2019-10-10 21:36:09 -04:00
toasted-nutbread
1dc8bf77ca Add input setting for custom audio source 2019-10-10 21:30:38 -04:00
toasted-nutbread
27c8430915 Implement custom audio source 2019-10-10 21:30:38 -04:00
toasted-nutbread
50252ec627 Update title with info about what the audio source was 2019-10-10 21:30:38 -04:00
toasted-nutbread
1d516b3b24 Implement audio fallbacks 2019-10-10 21:30:38 -04:00
toasted-nutbread
8ae1da4277 Update audio options format 2019-10-10 21:30:35 -04:00
toasted-nutbread
22b218d172 Pass optionsContext to audioBuildUrl handlers 2019-10-09 22:03:56 -04:00
toasted-nutbread
8be0ddeb26 Create region for audio options 2019-10-09 22:02:25 -04:00
toasted-nutbread
60a80418d7 Update how audio URLs are constructed 2019-10-09 21:54:58 -04:00
toasted-nutbread
7ce54864f3 Show the viewer button for anki notes which already exist 2019-10-09 20:31:09 -04:00
toasted-nutbread
97f5b7139f Add findNoteIds to AnkiConnect 2019-10-09 20:27:05 -04:00
toasted-nutbread
c5d6b9452d Create utility function for logging errors 2019-10-08 22:38:05 -04:00
toasted-nutbread
6a6e200ef9 Update rejections to use Error 2019-10-08 21:44:25 -04:00
toasted-nutbread
88de427184 Throw Error instead of string 2019-10-08 21:32:08 -04:00
toasted-nutbread
bf5d301685 Only use foreground api.js/util.js 2019-10-08 20:01:03 -04:00
toasted-nutbread
1074c33f20 Add support for query parameter in URL on search page 2019-10-08 20:01:03 -04:00
toasted-nutbread
9d488e1916 Validate that key is a string
On Chrome, when clicking an autocomplete dropdown menu option, a keydown event is generated which is not of type KeyboardEvent.
2019-10-08 19:32:44 -04:00
toasted-nutbread
176f6a248b Fix findTermMetaBulk trying to use undefined row.id 2019-10-07 22:34:40 -04:00
Alex Yatskov
7ccdb9134c
Merge pull request #243 from toasted-nutbread/svg-icons
SVG icons
2019-10-06 21:11:54 -07:00
toasted-nutbread
205c7d88d0 Remove PNG icons 2019-10-06 21:28:43 -04:00
toasted-nutbread
7c826fdd0b Switch from using PNGs to SVGs 2019-10-06 21:28:43 -04:00
toasted-nutbread
69b9cac8af Create SVG icons 2019-10-06 21:28:42 -04:00
c3926c67ad version bump 2019-10-06 09:07:22 -07:00
Alex Yatskov
14a5e3ce20
Merge pull request #238 from toasted-nutbread/deinflector-optimization
Deinflector optimization
2019-10-05 19:49:54 -07:00
Alex Yatskov
4df8662ea9
Merge pull request #234 from toasted-nutbread/remove-frontend-event-listeners
Remove event listeners when scanning is disabled
2019-10-05 19:48:46 -07:00
toasted-nutbread
113cc725c1 Make the window.onresize handler not change focus 2019-10-05 22:11:05 -04:00
toasted-nutbread
cd6d4e7ee1 Update how popup visibility works 2019-10-05 21:59:37 -04:00
toasted-nutbread
2255fadf52 Rename Popup.setVisible to setVisibleOverride 2019-10-05 21:40:10 -04:00
toasted-nutbread
50a47348a7 Optimize internal data structure used by the Deinflector class 2019-10-05 18:28:30 -04:00
toasted-nutbread
30263c3db8 Improve progressive/perfect deinflection rules 2019-10-05 18:21:39 -04:00
toasted-nutbread
c967b7a9f1 Remove event listeners when scanning is disabled 2019-10-05 13:57:33 -04:00
bac237336e version bump 2019-10-05 10:16:33 -07:00
Alex Yatskov
46ab36180f
Merge pull request #233 from toasted-nutbread/static-handlers
Static handlers
2019-10-05 09:20:45 -07:00
Alex Yatskov
440d6a91fd
Merge pull request #235 from toasted-nutbread/teiru-deinflections
Add support for progressive/perfect inflections
2019-10-05 09:19:31 -07:00
Alex Yatskov
a369f8d0a4
Merge pull request #229 from toasted-nutbread/database-optimizations
Database optimizations
2019-10-05 09:18:09 -07:00
toasted-nutbread
457caf2221 Add support for progressive/perfect inflections 2019-10-04 22:11:45 -04:00
toasted-nutbread
fa7ee468c0 Simplify float initialization 2019-10-02 21:12:24 -04:00
toasted-nutbread
7380ada1f1 Simplify onWheel handler 2019-10-02 21:12:24 -04:00
toasted-nutbread
0d6177398d Use static object for api command handlers 2019-10-02 21:12:24 -04:00
toasted-nutbread
10458c63e7 Use static object for backend message handlers 2019-10-02 21:12:23 -04:00
toasted-nutbread
bf382652a7 Use static object for float message handlers 2019-10-02 20:46:35 -04:00
toasted-nutbread
7d15213916 Use static object for frontend message handlers 2019-10-02 20:31:42 -04:00
toasted-nutbread
a628610cbd Use KeyboardEvent.key for onKeyDown handlers 2019-10-02 19:49:52 -04:00
toasted-nutbread
861474d2fc Fix inconsistent return type 2019-10-01 19:05:30 -04:00
Alex Yatskov
fba2bef905
Merge pull request #225 from toasted-nutbread/text-source-range-improvements
TextSourceRange improvements
2019-09-30 19:58:19 -07:00
Alex Yatskov
3c3a2c9474
Merge pull request #230 from toasted-nutbread/edge-fixes
Use toIterable for cross-window origin objects
2019-09-30 19:54:27 -07:00
Alex Yatskov
00d16433e7
Merge pull request #228 from toasted-nutbread/fix-tab-focus-changing
Fix tab focus being changed due to settings changes
2019-09-30 19:53:45 -07:00
toasted-nutbread
44119eea2c Fix deinflections not being handled correctly 2019-09-30 22:09:16 -04:00
toasted-nutbread
25a4dafd73 Fix tab focus being changed due to settings changes 2019-09-29 16:48:28 -04:00
toasted-nutbread
8b7558a757 Use toIterable for cross-window origin objects 2019-09-29 15:26:57 -04:00
toasted-nutbread
e18b8438ae Updated button styles 2019-09-29 12:33:16 -04:00
toasted-nutbread
1286b5115f Use bulk database searches 2019-09-28 22:05:10 -04:00
toasted-nutbread
664a318d7f Use non-async function for cache lookups 2019-09-28 21:54:18 -04:00
toasted-nutbread
a4f8a459de Create common function for creating term object 2019-09-28 21:49:08 -04:00
toasted-nutbread
888075d21a Add instructions for keyboard shortcuts 2019-09-28 16:04:22 -04:00
toasted-nutbread
5dfeca1500 Rename option for clarity 2019-09-28 16:04:22 -04:00
toasted-nutbread
305cf4703b Add info about third-party software licenses 2019-09-28 16:04:22 -04:00
toasted-nutbread
e7702e3bb4 Update URLs 2019-09-28 16:04:22 -04:00
toasted-nutbread
73133294e7 Update copyright years 2019-09-28 16:04:22 -04:00
toasted-nutbread
2a0cc44e6a Add header to settings page 2019-09-28 16:04:22 -04:00
toasted-nutbread
1a8cb78391 Add version information 2019-09-28 16:04:22 -04:00
toasted-nutbread
b42fa9581f Fix some incorrect labels 2019-09-28 16:04:22 -04:00
toasted-nutbread
9b929ffcd4 Add wrapping for usage conditions on small screens 2019-09-28 16:04:22 -04:00
toasted-nutbread
4e0fe1d5fb Limit width of the HTML pages 2019-09-28 16:04:22 -04:00
toasted-nutbread
9217b5c79b Move settings style to separate CSS file 2019-09-28 16:03:51 -04:00
toasted-nutbread
597f658b26 Move glyphicons into span element 2019-09-28 16:03:51 -04:00
toasted-nutbread
e5f24b8f12 Fix paragraph tags 2019-09-28 16:03:51 -04:00
toasted-nutbread
03c52625a9 Refactor seekForward and seekBackward 2019-09-28 11:28:55 -04:00
toasted-nutbread
a5f393fa2c Fix incorrect check 2019-09-28 11:28:15 -04:00
toasted-nutbread
928d7aecd5 Directly return rather than use a temporary variable 2019-09-28 11:28:15 -04:00
toasted-nutbread
8110de514e Change skipped node types to use a switch statement 2019-09-28 11:28:15 -04:00
toasted-nutbread
e358c94882 Clean up event listeners 2019-09-27 21:41:00 -04:00
toasted-nutbread
1a7ad30111 Remove jQuery dependency from float.html and search.html 2019-09-27 21:41:00 -04:00
toasted-nutbread
8db830b468 Change how current entry is indicated 2019-09-27 21:41:00 -04:00
toasted-nutbread
3ca84e3a85 Remove jQuery calls from adderButtonFind and viewerButtonFind 2019-09-27 21:41:00 -04:00
toasted-nutbread
946e577e42 Implement custom window scroll 2019-09-27 21:41:00 -04:00
toasted-nutbread
9fc69395c5 Use raw event listeners 2019-09-27 21:41:00 -04:00
toasted-nutbread
95a7fd81f5 Use raw element references for container and spinner 2019-09-27 21:41:00 -04:00
toasted-nutbread
355fb29c3b Use entryIndexFind without jQuery 2019-09-27 21:40:59 -04:00
toasted-nutbread
b61fc81012 Remove jQuery usage from search.js 2019-09-27 21:16:10 -04:00
toasted-nutbread
9a243630a5 Improve slide up animation 2019-09-27 21:16:10 -04:00
toasted-nutbread
476a5e873a Remove jQuery usage from float.js 2019-09-27 21:16:10 -04:00
odehjoseph
62b95a656f Add option to enable Alt+B lookup 2019-09-26 21:33:33 -07:00
f5afe590ad version bump 2019-09-23 17:34:18 -07:00
Alex Yatskov
ba2858309e
Merge pull request #218 from toasted-nutbread/settings-profile-conditions
Settings profile conditions
2019-09-23 17:03:00 -07:00
Alex Yatskov
db405ffd24
Merge pull request #219 from toasted-nutbread/fix-null-caret-position
Handle null return value of document.caretPositionFromPoint
2019-09-22 10:06:52 -07:00
toasted-nutbread
f022ee4eca Use a Promise to trigger callback when delay is 0 or less 2019-09-19 19:00:26 -04:00
toasted-nutbread
02927f9004 Handle null return value of document.caretPositionFromPoint 2019-09-18 22:11:18 -04:00
toasted-nutbread
352d214203 Isolate objects to background window 2019-09-18 19:14:04 -04:00
toasted-nutbread
dcfe722ba6 Add support for using optionsContext to select which profile to use 2019-09-18 19:14:04 -04:00
toasted-nutbread
8c4fb28a30 Add support creating profile usage conditions 2019-09-18 19:14:01 -04:00
Alex Yatskov
e3fb9603e2
Merge pull request #209 from toasted-nutbread/settings-profiles
Settings profiles
2019-09-16 18:32:01 -07:00
toasted-nutbread
073420a121 Normalize XHTML document node.nodeNode to upper case 2019-09-15 16:09:46 -04:00
toasted-nutbread
9fb89d8f7d Isolate to background window 2019-09-15 16:04:26 -04:00
toasted-nutbread
8b7e293eae Remove profile without popup when shift key is pressed
Also removes duplicate click listener.
2019-09-15 15:58:19 -04:00
toasted-nutbread
34ddbf25fe Implement profile order changing 2019-09-15 15:58:19 -04:00
toasted-nutbread
1f77506f43 Implement profile copy 2019-09-15 15:58:19 -04:00
toasted-nutbread
c002e1bbd2 Update dictionaries for all profile options 2019-09-15 15:58:19 -04:00
toasted-nutbread
6c571bf828 Add UI for profiles 2019-09-15 15:56:53 -04:00
toasted-nutbread
c8171f5ec7 Add preliminary support for profiles 2019-09-15 15:56:53 -04:00
Alex Yatskov
5877861277
Merge pull request #213 from toasted-nutbread/options-isolation
Isolate options objects created via settings.js
2019-09-15 11:34:34 -07:00
Alex Yatskov
e4fa658295
Merge pull request #212 from toasted-nutbread/frontend-cleanup
Frontend cleanup
2019-09-15 11:33:48 -07:00
Alex Yatskov
4af9fc2b3b
Merge pull request #214 from toasted-nutbread/add-anchor-noopener
URL improvements
2019-09-15 11:32:48 -07:00
Alex Yatskov
88a6128e39
Merge pull request #211 from toasted-nutbread/validate-content-window
Validate contentWindow before focus
2019-09-14 17:31:23 -07:00
Alex Yatskov
2add068ff2
Merge pull request #210 from toasted-nutbread/defer-port-creation
Defer creation of communication port until required
2019-09-14 17:30:52 -07:00
toasted-nutbread
f8aa926f8a Upgrade website URLs to https 2019-09-14 20:18:03 -04:00
toasted-nutbread
ba1875c56a Add rel="noopener" to all anchors with target="_blank" 2019-09-14 19:59:45 -04:00
toasted-nutbread
6358b655ae Isolate options objects created via settings.js
Prevents dead objects created by different windows.
2019-09-14 16:21:41 -04:00
toasted-nutbread
0067dfeacc Remove redundant call of popupTimerClear
Also use explicit null checks rather than truthy checks.
2019-09-14 15:29:43 -04:00
toasted-nutbread
8b1e4d1c6f Return only single element when deepDomScan is not enabled 2019-09-14 14:52:03 -04:00
toasted-nutbread
7dddcb8dca Rename type to cause 2019-09-14 14:31:21 -04:00
toasted-nutbread
6d3037f3d6 Remove destructuring from searchAt, containsPoint, docRangeFromPoint 2019-09-14 14:27:25 -04:00
toasted-nutbread
89941d404c Remove unused variable 2019-09-14 14:11:25 -04:00
toasted-nutbread
721248c821 Remove mouseDownLeft and mouseDownMiddle
MouseEvent.buttons can be used instead.
2019-09-14 14:11:06 -04:00
toasted-nutbread
964de775df Validate contentWindow before focus 2019-09-14 12:02:31 -04:00
toasted-nutbread
304064dae0 Defer creation of communication port until required 2019-09-14 11:58:22 -04:00
toasted-nutbread
bab6a13bfb Fix nested popups being shown if parent is hidden 2019-09-13 18:12:51 -04:00
Alex Yatskov
ec816e6767
Merge pull request #207 from toasted-nutbread/popup-proxy-writing-mode
Add writingMode to PopupProxy* termsShow and kanjiShow
2019-09-12 19:48:22 -07:00
Alex Yatskov
60b32a4a1a
Merge pull request #206 from toasted-nutbread/fix-incorrect-function-name
Replace profileCreateDefaultFieldTemplates with optionsFieldTemplates
2019-09-12 19:47:52 -07:00
toasted-nutbread
76aa30ceba Add writingMode to PopupProxy* termsShow and kanjiShow 2019-09-11 21:29:08 -04:00
toasted-nutbread
c38c7fbda1 Replace profileCreateDefaultFieldTemplates with optionsFieldTemplates 2019-09-11 19:56:13 -04:00
toasted-nutbread
84bd9ff93b Update settings if a different source triggers optionsUpdate 2019-09-10 21:58:53 -04:00
toasted-nutbread
71b700cd22 Add checkbox for options.general.enable 2019-09-10 21:45:43 -04:00
toasted-nutbread
87e513dd77 Fix options reference being changed 2019-09-10 21:44:32 -04:00
toasted-nutbread
1f8c7358cb Create function for setting up form event listeners 2019-09-10 21:43:52 -04:00
toasted-nutbread
36b39e2f65 Create formWrite function 2019-09-10 21:43:51 -04:00
toasted-nutbread
cab39e89c9 Create section for Popup Content Scanning Options 2019-09-10 21:43:51 -04:00
toasted-nutbread
c4e6d7e3d1 Add utility method for checking if a value is a standard object 2019-09-10 20:09:33 -04:00
toasted-nutbread
05ce350792 Use apiOptionsSave instead of optionsSave 2019-09-10 20:09:33 -04:00
toasted-nutbread
4686a31a0a Use apiOptionsGet instead of optionsLoad 2019-09-10 20:09:33 -04:00
toasted-nutbread
99cec1d23f Change how formRead works
The function now modifies values in-place.
2019-09-10 20:09:33 -04:00
toasted-nutbread
8175f80183 Remove calls to apiOptionsGetSync
Use apiOptionsGet everywhere to ensure options is initialized.
2019-09-10 20:09:33 -04:00
toasted-nutbread
1b2a1e50eb Add getOptions function to backend 2019-09-10 20:09:33 -04:00
toasted-nutbread
bc8793eb56 Add a context object for all calls to fetch options 2019-09-10 20:09:33 -04:00
toasted-nutbread
99ca60d4c1 Ensure both Popup and PopupProxy have valid depth 2019-09-10 20:09:33 -04:00
toasted-nutbread
aae971a09e Pass options directly to translator.findTerms* 2019-09-10 20:09:33 -04:00
toasted-nutbread
91bc31d758 Change how options updates are handled on the frontend
Only an 'optionsUpdate' signal is now sent to the frontend with empty data. The frontend then responds by performing apiOptionsGet to update the options. This makes it so that there is only a single function which is responsible for requesting options from the backend.
2019-09-10 20:09:33 -04:00
Alex Yatskov
cc53510883
Merge pull request #204 from toasted-nutbread/settings-improvements
Settings improvements
2019-09-08 19:34:39 -07:00
toasted-nutbread
eb98dfb1a8 Simplify logic for how option updates are propagated 2019-09-06 21:23:35 -04:00
toasted-nutbread
7db2c66105 Use consistent structure for params 2019-09-06 21:23:35 -04:00
toasted-nutbread
13b184707b Remove unnecessary functions
apiOptionsSet not required in bg/js/api.js after optionsSave; optionsSave already invokes apiOptionsSet.
apiOptionsSet not required in fg/js/api.js since it's never invoked by the foreground.
optionsSet handler not required in bg/js/backend.js since the message is never sent by the foreground.
2019-09-06 21:23:35 -04:00