sabs
fd17a0fccd
Remove Download check when resolving Audio data
...
There is a bug (seemingly unreported) in Yomichan where an Anki card
will not contain any audio if the JapanesePod101 audio source trumps
a secondary audio source (e.g. JapanesePod101-alternate) where
the jpod101 source can't find the word requested.
For example, そして has an audio entry in the alternate source but not
the standard source.
(Alternatively, there may be a bug in the jpod101 audioUrlBuilder,
because I've only noticed this problem with hiragana-only expressions.
JPod101 may not host those on the same url scheme any more. I'm not
sure how to fix that, though, and the bug I'm addressing here does
still persist).
The reason this happens is that audioGetFromUrl uses downloaded audio
to effectively check for a 404 (by examining the audio duration), but
that check doesn't happen when an Anki card is being created (i.e.
"download" is set, which I've changed to "willDownload" here).
This change removes that check, but retains the will-download intent
information to prevent attempts to download tts data, which AnkiConnect
cannot do. I've also added a short explanation as to why the download
check happens where it does.
I think the unused audio object will get garbage collected since it's
not referenced again, but I've explicitly unset it as well.
2019-11-09 20:58:09 -05:00
toasted-nutbread
3e864c44c3
Fixes for Edge
2019-11-09 20:52:16 -05:00
siikamiika
4ac4128388
search page checkbox styling
...
Change checkboxes to color-inverting icons
2019-11-10 03:15:55 +02:00
toasted-nutbread
184cc4cf28
Allow templates to be tested on the settings page
2019-11-09 16:34:39 -05:00
toasted-nutbread
085881d342
Use HTML templates for anki fields
2019-11-09 14:31:13 -05:00
siikamiika
40c8268fd6
always disable scanning IME checkbox label
2019-11-09 13:01:21 +02:00
siikamiika
cf0bb0a9e2
enable custom CSS on search page
2019-11-09 12:43:22 +02:00
siikamiika
177fad56b5
use scan toggling for stroke order diagram too
2019-11-09 12:28:12 +02:00
siikamiika
25af532ab7
enable expression scan toggling on search page
2019-11-09 12:27:09 +02:00
toasted-nutbread
b59a5b8cdb
Add support for some regex functions in handlebars templates
2019-11-08 22:57:20 -05:00
toasted-nutbread
4d7940e8e4
Optimize dictFieldFormat
2019-11-08 22:25:03 -05:00
toasted-nutbread
fa963722a7
Fix seekForward and seekBackward not handling length=0 case correctly
2019-11-08 19:24:33 -05:00
toasted-nutbread
b059609670
Add outdated warning
2019-11-07 20:30:55 -05:00
toasted-nutbread
cad0648cbe
Remove unused function
2019-11-07 20:30:55 -05:00
toasted-nutbread
f7700789fe
Update dictionary order based on priority
2019-11-07 20:30:55 -05:00
toasted-nutbread
fcb922400a
Prevent page exit while database operations are in progress
2019-11-07 20:30:55 -05:00
toasted-nutbread
e5dcb41824
Add support for importing multiple dictionaries at once
2019-11-07 20:30:55 -05:00
toasted-nutbread
e091c7ebe2
Add support for deleting individual dictionaries
2019-11-07 20:30:55 -05:00
toasted-nutbread
e355b83914
Update how nodes are hidden
2019-11-07 20:30:55 -05:00
toasted-nutbread
3d78d5400d
Add button and confirmation dialog for database purge
2019-11-07 20:30:55 -05:00
toasted-nutbread
2ab871e7ee
Update how dictionaries are displayed on the settings page
2019-11-07 20:30:55 -05:00
toasted-nutbread
79069d5908
Add functions for getting dictionary information
2019-11-07 20:30:55 -05:00
toasted-nutbread
44638b7ceb
Simplify how option visibility is changed
2019-11-07 20:30:55 -05:00
91c01e0a7e
Update version
2019-11-05 19:03:23 -08:00
toasted-nutbread
a85ec440d6
Fix overlapping popup timers
2019-11-05 19:48:08 -05:00
siikamiika
83460bcdad
refactoring and optimization
2019-11-04 02:15:33 +02:00
siikamiika
f4a987912a
prevent accidental lookup on glossary text select
2019-11-03 18:56:22 +02:00
toasted-nutbread
75ff05148d
Fix autoHideResults not working
2019-11-03 11:06:31 -05:00
toasted-nutbread
7de24dd355
Add favicons
2019-11-02 10:10:03 -04:00
toasted-nutbread
60c0a002df
Force LF line endings for template files
2019-10-28 17:33:30 -04:00
toasted-nutbread
bcffe80a1e
Group similar functions together
2019-10-28 17:03:42 -04:00
toasted-nutbread
6d85dae68d
Fix some issues with the context menu
2019-10-28 17:03:42 -04:00
toasted-nutbread
d2644c0776
Style update
2019-10-28 17:03:42 -04:00
toasted-nutbread
c365101ec2
Reset preventions earlier
2019-10-28 17:03:42 -04:00
toasted-nutbread
e542f38110
Check pendingLookup earlier
2019-10-28 17:03:42 -04:00
toasted-nutbread
9703e123bf
Remove setPrimaryTouch
2019-10-28 17:03:42 -04:00
toasted-nutbread
80eb357527
Simplify touch event implementation
2019-10-28 17:03:42 -04:00
toasted-nutbread
131dc8397d
Make selectionContainsPoint static
2019-10-28 17:03:42 -04:00
toasted-nutbread
a648e05091
Improve naming
2019-10-28 17:03:42 -04:00
toasted-nutbread
9178636613
Remove setters
2019-10-28 17:03:42 -04:00
toasted-nutbread
c74c466c36
Remove unused variable
2019-10-28 17:03:42 -04:00
toasted-nutbread
f2dec4ca20
Remove searchFromTouch
2019-10-28 17:03:42 -04:00
toasted-nutbread
8c5240d7a6
Simplify how touch events use onAfterSearch
2019-10-28 17:03:42 -04:00
toasted-nutbread
e91bcf5f55
Rename textSourceLast to textSourceCurrent
2019-10-28 17:03:42 -04:00
toasted-nutbread
be27781c15
Update how definitions are searched for
2019-10-28 17:03:42 -04:00
toasted-nutbread
f927f806ba
Move check
2019-10-28 17:03:42 -04:00
toasted-nutbread
1f0a434e96
Remove unused vars
2019-10-28 17:03:42 -04:00
toasted-nutbread
dcb6f68826
Don't pass null textSource into searchSource
2019-10-28 17:03:42 -04:00
toasted-nutbread
185963899b
Use promiseTimeout
2019-10-28 17:03:42 -04:00
toasted-nutbread
d608657495
Move onError catch into searchAt
2019-10-28 17:03:42 -04:00
