alex/yomichan
1
Fork 0
Code Releases Activity

Simplify event to use bind

Browse Source
This commit is contained in:
toasted-nutbread 2020-02-26 21:19:22 -05:00
parent 2d109c3e56
commit fdfc2d33bb
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ext/bg/js/settings/popup-preview-frame.js
View File

@ -46,10 +46,7 @@ class SettingsPopupPreview {
// Setup events
window.addEventListener('message', this.onMessage.bind(this), false);
const themeDarkCheckbox = document.querySelector('#theme-dark-checkbox');
if (themeDarkCheckbox !== null) {
themeDarkCheckbox.addEventListener('change', () => this.onThemeDarkCheckboxChanged(themeDarkCheckbox), false);
}
document.querySelector('#theme-dark-checkbox').addEventListener('change', this.onThemeDarkCheckboxChanged.bind(this), false);
// Overwrite API functions
window.apiOptionsGet = this.apiOptionsGet.bind(this);
@ -113,8 +110,8 @@ class SettingsPopupPreview {
handler(params);
}
onThemeDarkCheckboxChanged(node) {
document.documentElement.classList.toggle('dark', node.checked);
onThemeDarkCheckboxChanged(e) {
document.documentElement.classList.toggle('dark', e.target.checked);
if (this.themeChangeTimeout !== null) {
clearTimeout(this.themeChangeTimeout);
}