alex/yomichan
1
Fork 0
Code Releases Activity

SettingsController API update (#579)

Browse Source 
* Include optionsContext as part of optionsChanged event

* Add get/modify functions
This commit is contained in:
toasted-nutbread 2020-05-30 11:24:34 -04:00 committed by GitHub
parent 789da0206b
commit f228078613
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
ext/bg/js/settings/settings-controller.js
View File

@ -70,6 +70,30 @@ class SettingsController extends EventDispatcher {
await this.save();
}
async getGlobalSettings(targets) {
return await this._getSettings(targets, {scope: 'global'});
}
async getProfileSettings(targets) {
return await this._getSettings(targets, {scope: 'profile', optionsContext: this.getOptionsContext()});
}
async modifyGlobalSettings(targets) {
return await this._modifySettings(targets, {scope: 'global'});
}
async modifyProfileSettings(targets) {
return await this._modifySettings(targets, {scope: 'profile', optionsContext: this.getOptionsContext()});
}
async setGlobalSetting(path, value) {
return await this.modifyGlobalSettings([{action: 'set', path, value}]);
}
async setProfileSetting(path, value) {
return await this.modifyProfileSettings([{action: 'set', path, value}]);
}
getOptionsContext() {
return {index: this._profileIndex};
}
@ -82,7 +106,18 @@ class SettingsController extends EventDispatcher {
}
async _onOptionsUpdatedInternal() {
const optionsContext = this.getOptionsContext();
const options = await this.getOptions();
this.trigger('optionsChanged', {options});
this.trigger('optionsChanged', {options, optionsContext});
}
async _getSettings(targets, extraFields) {
targets = targets.map((target) => Object.assign({}, target, extraFields));
return await api.getSettings(targets);
}
async _modifySettings(targets, extraFields) {
targets = targets.map((target) => Object.assign({}, target, extraFields));
return await api.modifySettings(targets, this._source);
}
}