From eea95eb130e8c444b93353f68f417ad2390795d7 Mon Sep 17 00:00:00 2001
From: toasted-nutbread <toasted-nutbread@users.noreply.github.com>
Date: Sat, 19 Oct 2019 14:18:57 -0400
Subject: [PATCH] Simplify score to term frequency conversion

---
 ext/bg/js/translator.js | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/ext/bg/js/translator.js b/ext/bg/js/translator.js
index de7ebc2b..ee012d96 100644
--- a/ext/bg/js/translator.js
+++ b/ext/bg/js/translator.js
@@ -135,19 +135,12 @@ class Translator {
         for (const expression of result.expressions.keys()) {
             for (const reading of result.expressions.get(expression).keys()) {
                 const termTags = result.expressions.get(expression).get(reading);
+                const score = termTags.map(tag => tag.score).reduce((p, v) => p + v, 0);
                 expressions.push({
                     expression: expression,
                     reading: reading,
                     termTags: dictTagsSort(termTags),
-                    termFrequency: (score => {
-                        if (score > 0) {
-                            return 'popular';
-                        } else if (score < 0) {
-                            return 'rare';
-                        } else {
-                            return 'normal';
-                        }
-                    })(termTags.map(tag => tag.score).reduce((p, v) => p + v, 0))
+                    termFrequency: Translator.scoreToTermFrequency(score)
                 });
             }
         }
@@ -470,6 +463,16 @@ class Translator {
         return tagMetaList;
     }
 
+    static scoreToTermFrequency(score) {
+        if (score > 0) {
+            return 'popular';
+        } else if (score < 0) {
+            return 'rare';
+        } else {
+            return 'normal';
+        }
+    }
+
     static getNameBase(name) {
         const pos = name.indexOf(':');
         return (pos >= 0 ? name.substr(0, pos) : name);