alex/yomichan
1
Fork 0
Code Releases Activity

Fix repeated note IDs shown on the "View Note" button (#1927)

Browse Source
This commit is contained in:
toasted-nutbread 2021-09-03 22:42:27 -04:00 committed by GitHub
parent 0331374241
commit eb457caea9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ext/js/display/display-anki.js
View File

@ -255,7 +255,7 @@ class DisplayAnki {
const displayTags = this._displayTags; const displayTags = this._displayTags;
const dictionaryEntryDetails = this._dictionaryEntryDetails; const dictionaryEntryDetails = this._dictionaryEntryDetails;
for (let i = 0, ii = dictionaryEntryDetails.length; i < ii; ++i) { for (let i = 0, ii = dictionaryEntryDetails.length; i < ii; ++i) {
const allNoteIds = []; let allNoteIds = null;
for (const {mode, canAdd, noteIds, noteInfos, ankiError} of dictionaryEntryDetails[i].modeMap.values()) { for (const {mode, canAdd, noteIds, noteInfos, ankiError} of dictionaryEntryDetails[i].modeMap.values()) {
const button = this._adderButtonFind(i, mode); const button = this._adderButtonFind(i, mode);
if (button !== null) { if (button !== null) {
@ -264,14 +264,15 @@ class DisplayAnki {
} }
if (Array.isArray(noteIds) && noteIds.length > 0) { if (Array.isArray(noteIds) && noteIds.length > 0) {
allNoteIds.push(...noteIds); if (allNoteIds === null) { allNoteIds = new Set(); }
for (const noteId of noteIds) { allNoteIds.add(noteId); }
} }
if (displayTags !== 'never' && Array.isArray(noteInfos)) { if (displayTags !== 'never' && Array.isArray(noteInfos)) {
this._setupTagsIndicator(i, noteInfos); this._setupTagsIndicator(i, noteInfos);
} }
} }
this._updateViewNoteButton(i, allNoteIds, false); this._updateViewNoteButton(i, allNoteIds !== null ? [...allNoteIds] : [], false);
} }
} }