alex/yomichan
1
Fork 0
Code Releases Activity

More build script improvements (#1123)

Browse Source 
* Update set action to support an assignment index

* Add 'add' modification
This commit is contained in:
toasted-nutbread 2020-12-18 15:24:12 -05:00 committed by GitHub
parent 5dc7bc0e15
commit df7834a880
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
dev/build.js
View File

@ -82,10 +82,16 @@ function applyModifications(manifest, modifications) {
switch (action) { switch (action) {
case 'set': case 'set':
{ {
const {value: newValue} = modification; const {value, before, after} = modification;
const value = getObjectProperties(manifest, path2, path2.length - 1); const object = getObjectProperties(manifest, path2, path2.length - 1);
const last = path2[path2.length - 1]; const key = path2[path2.length - 1];
value[last] = clone(newValue);
let {index} = modification;
if (typeof index !== 'number') { index = -1; }
if (typeof before === 'string') { index = getObjectKeyIndex(object, before); }
if (typeof after === 'string') { index = getObjectKeyIndex(object, after); }
setObjectKeyAtIndex(object, key, value, index);
} }
break; break;
case 'replace': case 'replace':
@ -143,6 +149,14 @@ function applyModifications(manifest, modifications) {
} }
} }
break; break;
case 'add':
{
const {items} = modification;
const value = getObjectProperties(manifest, path2, path2.length);
const itemsNew = items.map((v) => clone(v));
value.push(...itemsNew);
}
break;
} }
} }
} }
@ -165,7 +179,7 @@ function getObjectKeyIndex(object, key) {
} }
function setObjectKeyAtIndex(object, key, value, index) { function setObjectKeyAtIndex(object, key, value, index) {
if (index < 0 || Object.prototype.hasOwnProperty.call(object, key)) { if (index < 0 || typeof key === 'number' || Object.prototype.hasOwnProperty.call(object, key)) {
object[key] = value; object[key] = value;
return; return;
} }