alex/yomichan
1
Fork 0
Code Releases Activity

Fix old settings page not being used properly (#1376)

Browse Source
This commit is contained in:
toasted-nutbread 2021-02-12 23:07:19 -05:00 committed by GitHub
parent 4053d9b2fa
commit daea80942c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ext/bg/js/backend.js
View File

@ -1831,7 +1831,7 @@ class Backend {
async _openSettingsPage(mode) { async _openSettingsPage(mode) {
const {useSettingsV2} = this._options.global; const {useSettingsV2} = this._options.global;
const manifest = chrome.runtime.getManifest(); const manifest = chrome.runtime.getManifest();
const url = chrome.runtime.getURL(useSettingsV2 ? '/settings.html' : manifest.options_ui.page); const url = chrome.runtime.getURL(useSettingsV2 ? manifest.options_ui.page : '/settings-old.html');
switch (mode) { switch (mode) {
case 'existingOrNewTab': case 'existingOrNewTab':
if (useSettingsV2) { if (useSettingsV2) {

2
ext/bg/js/context-main.js
View File

@ -40,7 +40,7 @@ class DisplayController {
this._setupHotkeys(); this._setupHotkeys();
const optionsPageUrl = optionsFull.global.useSettingsV2 ? '/settings.html' : manifest.options_ui.page; const optionsPageUrl = optionsFull.global.useSettingsV2 ? manifest.options_ui.page : '/settings-old.html';
this._setupButtonEvents('.action-open-settings', 'openSettingsPage', chrome.runtime.getURL(optionsPageUrl)); this._setupButtonEvents('.action-open-settings', 'openSettingsPage', chrome.runtime.getURL(optionsPageUrl));
this._setupButtonEvents('.action-open-permissions', null, chrome.runtime.getURL('/permissions.html')); this._setupButtonEvents('.action-open-permissions', null, chrome.runtime.getURL('/permissions.html'));