alex/yomichan
1
Fork 0
Code Releases Activity

Fix an issue with reordering dictionary settings (#1812)

Browse Source
This commit is contained in:
toasted-nutbread 2021-07-09 16:06:12 -04:00 committed by GitHub
parent 24ec22b2e1
commit daa44a8389
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ext/js/pages/settings/collapsible-dictionary-controller.js
View File

@ -33,6 +33,7 @@ class CollapsibleDictionaryController {
yomichan.on('databaseUpdated', this._onDatabaseUpdated.bind(this)); yomichan.on('databaseUpdated', this._onDatabaseUpdated.bind(this));
this._settingsController.on('optionsChanged', this._onOptionsChanged.bind(this)); this._settingsController.on('optionsChanged', this._onOptionsChanged.bind(this));
this._settingsController.on('dictionarySettingsReordered', this._onDictionarySettingsReordered.bind(this));
} }
// Private // Private
@ -88,6 +89,11 @@ class CollapsibleDictionaryController {
this._setDefinitionsCollapsibleAll(value); this._setDefinitionsCollapsibleAll(value);
} }
async _onDictionarySettingsReordered() {
const options = await this._settingsController.getOptions();
this._onOptionsChanged({options});
}
_setupAllSelect(fragment, options) { _setupAllSelect(fragment, options) {
const select = this._addSelect(fragment, 'All', ''); const select = this._addSelect(fragment, 'All', '');

2
ext/js/pages/settings/dictionary-controller.js
View File

@ -325,6 +325,8 @@ class DictionaryController {
value: dictionaries value: dictionaries
}]); }]);
this._settingsController.trigger('dictionarySettingsReordered', {source: this});
await this._updateEntries(); await this._updateEntries();
} }

6
ext/js/pages/settings/secondary-search-dictionary-controller.js
View File

@ -31,6 +31,7 @@ class SecondarySearchDictionaryController {
yomichan.on('databaseUpdated', this._onDatabaseUpdated.bind(this)); yomichan.on('databaseUpdated', this._onDatabaseUpdated.bind(this));
this._settingsController.on('optionsChanged', this._onOptionsChanged.bind(this)); this._settingsController.on('optionsChanged', this._onOptionsChanged.bind(this));
this._settingsController.on('dictionarySettingsReordered', this._onDictionarySettingsReordered.bind(this));
} }
// Private // Private
@ -84,4 +85,9 @@ class SecondarySearchDictionaryController {
const {detail: {value}} = e; const {detail: {value}} = e;
node.dataset.enabled = `${value}`; node.dataset.enabled = `${value}`;
} }
async _onDictionarySettingsReordered() {
const options = await this._settingsController.getOptions();
this._onOptionsChanged({options});
}
} }