alex/yomichan
1
Fork 0
Code Releases Activity

Fix options not being propagated fully after being updated (#1025)

Browse Source
This commit is contained in:
toasted-nutbread 2020-11-13 19:51:51 -05:00 committed by GitHub
parent 3edc35691b
commit d62d353958
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ext/fg/js/popup.js
View File

@ -105,9 +105,8 @@ class Popup extends EventDispatcher {
}
async setOptionsContext(optionsContext) {
this._optionsContext = optionsContext;
this._options = await api.optionsGet(optionsContext);
this.updateTheme();
await this._setOptionsContext(optionsContext);
await this._invokeSafe('setOptionsContext', {optionsContext});
}
hide(changeFocus) {
@ -655,8 +654,14 @@ class Popup extends EventDispatcher {
};
}
async _setOptionsContext(optionsContext) {
this._optionsContext = optionsContext;
this._options = await api.optionsGet(optionsContext);
this.updateTheme();
}
async _setOptionsContextIfDifferent(optionsContext) {
if (deepEqual(this._optionsContext, optionsContext)) { return; }
await this.setOptionsContext(optionsContext);
await this._setOptionsContext(optionsContext);
}
}