alex/yomichan
1
Fork 0
Code Releases Activity

Test link hrefs (#999)

Browse Source 
* Add validatePath function

* Validate <link>s
This commit is contained in:
toasted-nutbread 2020-11-07 11:30:21 -05:00 committed by GitHub
parent f4325b7db9
commit ca26c648c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
dev/lint/html-scripts.js
View File

@ -31,23 +31,28 @@ function lstatSyncSafe(fileName) {
} }
} }
function validatePath(src, fileName, extDir) {
assert.ok(typeof src === 'string', `<script> missing src attribute in ${fileName}`);
assert.ok(src.startsWith('/'), `<script> src attribute is not absolute in ${fileName} (src=${JSON.stringify(src)})`);
const relativeSrc = src.substring(1);
assert.ok(!path.isAbsolute(relativeSrc), `<script> src attribute is invalid in ${fileName} (src=${JSON.stringify(src)})`);
const fullSrc = path.join(extDir, relativeSrc);
const stats = lstatSyncSafe(fullSrc);
assert.ok(stats !== null, `<script> src file not found in ${fileName} (src=${JSON.stringify(src)})`);
assert.ok(stats.isFile(), `<script> src file invalid in ${fileName} (src=${JSON.stringify(src)})`);
}
function validateHtmlScripts(fileName, extDir) { function validateHtmlScripts(fileName, extDir) {
const domSource = fs.readFileSync(fileName, {encoding: 'utf8'}); const domSource = fs.readFileSync(fileName, {encoding: 'utf8'});
const dom = new JSDOM(domSource); const dom = new JSDOM(domSource);
const {window} = dom; const {window} = dom;
const {document} = window; const {document} = window;
try { try {
const scripts = document.querySelectorAll('script'); for (const {src} of document.querySelectorAll('script')) {
for (const script of scripts) { validatePath(src, fileName, extDir);
const {src} = script; }
assert.ok(typeof src === 'string', `<script> missing src attribute in ${fileName}`); for (const {href} of document.querySelectorAll('link')) {
assert.ok(src.startsWith('/'), `<script> src attribute is not absolute in ${fileName} (src=${JSON.stringify(src)})`); validatePath(href, fileName, extDir);
const relativeSrc = src.substring(1);
assert.ok(!path.isAbsolute(relativeSrc), `<script> src attribute is invalid in ${fileName} (src=${JSON.stringify(src)})`);
const fullSrc = path.join(extDir, relativeSrc);
const stats = lstatSyncSafe(fullSrc);
assert.ok(stats !== null, `<script> src file not found in ${fileName} (src=${JSON.stringify(src)})`);
assert.ok(stats.isFile(), `<script> src file invalid in ${fileName} (src=${JSON.stringify(src)})`);
} }
} finally { } finally {
window.close(); window.close();