alex/yomichan
1
Fork 0
Code Releases Activity

Create utility function for logging errors

Browse Source
This commit is contained in:
toasted-nutbread 2019-10-08 21:33:10 -04:00
parent 6a6e200ef9
commit c5d6b9452d
4 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ext/bg/js/search.js
View File

@ -53,7 +53,7 @@ class DisplaySearch extends Display {
}
onError(error) {
window.alert(`Error: ${error.toString ? error.toString() : error}`);
logError(error, true);
}
onSearchClear() {

2
ext/fg/js/float.js
View File

@ -37,7 +37,7 @@ class DisplayFloat extends Display {
if (window.yomichan_orphaned) {
this.onOrphaned();
} else {
window.alert(`Error: ${error.toString ? error.toString() : error}`);
logError(error, true);
}
}

2
ext/fg/js/frontend.js
View File

@ -228,7 +228,7 @@ class Frontend {
}
onError(error) {
console.log(error);
logError(error, false);
}
setEnabled(enabled) {

18
ext/mixed/js/extension.js
View File

@ -68,6 +68,24 @@ function jsonToError(jsonError) {
return error;
}
function logError(error, alert) {
const manifest = chrome.runtime.getManifest();
let errorMessage = `${manifest.name} v${manifest.version} has encountered an error.\n`;
errorMessage += `Originating URL: ${window.location.href}\n`;
const errorString = `${error.toString ? error.toString() : error}`;
const stack = `${error.stack}`.trimRight();
errorMessage += (!stack.startsWith(errorString) ? `${errorString}\n${stack}` : `${stack}`);
errorMessage += '\n\nIssues can be reported at https://github.com/FooSoft/yomichan/issues';
console.error(errorMessage);
if (alert) {
window.alert(`${errorString}\n\nCheck the developer console for more details.`);
}
}
const EXTENSION_IS_BROWSER_EDGE = (
extensionHasBrowser() &&
(!extensionHasChrome() || (typeof chrome.runtime === 'undefined' && typeof browser.runtime !== 'undefined'))