From c2aa51fdbb748d40fcbbd7708369436fb83a63ff Mon Sep 17 00:00:00 2001
From: toasted-nutbread <toasted-nutbread@users.noreply.github.com>
Date: Thu, 8 Apr 2021 22:04:11 -0400
Subject: [PATCH] Minor updates to settings styles (#1601)

---
 ext/css/settings.css | 15 +++------------
 ext/settings.html    |  7 +++----
 2 files changed, 6 insertions(+), 16 deletions(-)

diff --git a/ext/css/settings.css b/ext/css/settings.css
index 22439409..c0e75fc2 100644
--- a/ext/css/settings.css
+++ b/ext/css/settings.css
@@ -1312,9 +1312,6 @@ body.preview-sidebar-visible .fab-container-item.fab-container-item-popup-previe
 #audio-source-list-empty {
     display: none;
 }
-#audio-source-list:empty+#audio-source-list-empty {
-    display: block;
-}
 
 .dictionary-info {
     display: flex;
@@ -1685,9 +1682,6 @@ code.anki-field-marker {
 .scan-input-list {
     margin: 0 calc(var(--modal-padding-horizontal) * -1);
 }
-.scan-input-list:not(:empty)+.scan-input-list-empty-info {
-    display: none;
-}
 .scan-input {
     margin: 0.5em 0;
 }
@@ -1802,12 +1796,6 @@ code.anki-field-marker {
     height: calc(0.425em * 4 + 1em * var(--line-height-default) * 3);
 }
 
-#translation-text-replacement-list-empty {
-    display: none;
-}
-#translation-text-replacement-list:empty+#translation-text-replacement-list-empty {
-    display: block;
-}
 .translation-text-replacement-entry {
     display: grid;
     grid-template-columns: auto auto 1fr auto;
@@ -2195,6 +2183,9 @@ button.hotkey-list-item-enabled-button[data-scope-count='0'] {
     counter-increment: generic-list-index;
     content: counter(generic-list-index);
 }
+.generic-list:not(:empty)~.generic-list-empty-indicator {
+    display: none;
+}
 
 .flex-row-nowrap {
     display: flex;
diff --git a/ext/settings.html b/ext/settings.html
index 3e2b6237..d629e6a6 100644
--- a/ext/settings.html
+++ b/ext/settings.html
@@ -2377,7 +2377,7 @@
 <!-- Audio templates -->
 <template id="audio-source-template"><div class="audio-source horizontal-flex">
     <div class="generic-list-index-prefix"></div>
-    <select class="audio-source-select">
+    <select class="audio-source-select horizontal-flex-fill">
         <option value="jpod101">JapanesePod101</option>
         <option value="jpod101-alternate">JapanesePod101 (Alternate)</option>
         <option value="jisho">Jisho.org</option>
@@ -2385,7 +2385,6 @@
         <option value="text-to-speech-reading">Text-to-speech (Kana reading)</option>
         <option value="custom">Custom</option>
     </select>
-    <div class="horizontal-flex-fill"></div>
     <button class="icon-button audio-source-menu-button" data-menu="audio-source-menu" data-menu-position="below left"><span class="icon-button-inner"><span class="icon" data-icon="kebab-menu"></span></span></button>
 </div></template>
 
@@ -2440,7 +2439,7 @@
             </div>
         </div>
         <div class="scan-input-list generic-list margin-above" id="scan-input-list"></div>
-        <div class="scan-input-list-empty-info warning-text margin-above">
+        <div class="warning-text margin-above generic-list-empty-indicator">
             No scanning inputs have been defined yet.
             Click the <em>Add</em> button to add a new input.
         </div>
@@ -2960,7 +2959,7 @@
             </div>
             <div class="settings-item-children">
                 <div id="translation-text-replacement-list" class="generic-list"></div>
-                <div id="translation-text-replacement-list-empty"><em>None defined</em></div>
+                <div class="generic-list-empty-indicator"><em>None defined</em></div>
             </div>
         </div>
     </div>