Scanning mouse button fixes (#866)

* Move mouse0 blocking during mousemove into options

* Update primary button detection

ext/bg/data/options-schema.json

@@ -343,7 +343,7 @@
                                         "default": [
                                             {
                                                 "include": "shift",
-                                                "exclude": "",
+                                                "exclude": "mouse0",
                                                 "types": {
                                                     "mouse": true,
                                                     "touch": false,

ext/bg/js/options.js

@@ -550,7 +550,7 @@ class OptionsUtil {
             }
             scanningInputs.push({
                 include: modifierInput,
-                exclude: '',
+                exclude: 'mouse0',
                 types: {mouse: true, touch: false, pen: false},
                 options: createInputDefaultOptions()
             });

ext/mixed/js/document-util.js

@@ -169,16 +169,6 @@ class DocumentUtil {
         }
     }
 
-    static isMouseButtonDown(mouseEvent, button) {
-        const mouseEventButtons = mouseEvent.buttons;
-        switch (button) {
-            case 'primary': return (mouseEventButtons & 0x1) !== 0x0;
-            case 'secondary': return (mouseEventButtons & 0x2) !== 0x0;
-            case 'auxiliary': return (mouseEventButtons & 0x4) !== 0x0;
-            default: return false;
-        }
-    }
-
     static getActiveModifiers(event) {
         const modifiers = new Set();
         if (event.altKey) { modifiers.add('alt'); }

ext/mixed/js/text-scanner.js

@@ -267,10 +267,6 @@ class TextScanner extends EventDispatcher {
     _onMouseMove(e) {
         this._scanTimerClear();
 
-        if (DocumentUtil.isMouseButtonDown(e, 'primary')) {
-            return;
-        }
-
         const inputInfo = this._getMatchingInputGroupFromEvent(e, 'mouse');
         if (inputInfo === null) { return; }
 
@@ -286,7 +282,7 @@ class TextScanner extends EventDispatcher {
             return false;
         }
 
-        if (DocumentUtil.isMouseButtonDown(e, 'primary')) {
+        if (e.button === 0) { // Primary
             this._scanTimerClear();
             this.clearSelection(false);
         }

test/test-options-util.js

@@ -319,7 +319,7 @@ function createProfileOptionsUpdatedTestData1() {
             inputs: [
                 {
                     include: 'shift',
-                    exclude: '',
+                    exclude: 'mouse0',
                     types: {
                         mouse: true,
                         touch: false,