alex/yomichan
1
Fork 0
Code Releases Activity

hide search input in native popups

Browse Source
This commit is contained in:
siikamiika 2020-02-02 16:08:19 +02:00
parent 8d56d6ffcb
commit c16c38638b
4 changed files with 44 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ext/bg/js/backend.js
View File

@ -603,8 +603,10 @@ class Backend {
const {popupWidth, popupHeight} = options.general;
const baseUrl = chrome.runtime.getURL('/bg/search.html');
const queryString = (query && query.length > 0) ? `?query=${encodeURIComponent(query)}` : '';
const url = baseUrl + queryString;
const queryParams = {mode};
if (query && query.length > 0) { queryParams.query = query; }
const queryString = new URLSearchParams(queryParams).toString();
const url = `${baseUrl}?${queryString}`;
switch (mode) {
case 'sameTab':

19
ext/bg/js/search.js
View File

@ -53,6 +53,8 @@ class DisplaySearch extends Display {
this.search.addEventListener('click', (e) => this.onSearch(e), false);
}
if (this.query !== null) {
const {query='', mode=''} = DisplaySearch.parseQueryStringFromLocation(window.location.href);
document.documentElement.dataset.searchMode = mode;
this.query.addEventListener('input', () => this.onSearchInput(), false);
if (this.wanakanaEnable !== null) {
@ -63,7 +65,6 @@ class DisplaySearch extends Display {
this.wanakanaEnable.checked = false;
}
this.wanakanaEnable.addEventListener('change', (e) => {
const query = DisplaySearch.getSearchQueryFromLocation(window.location.href) || '';
if (e.target.checked) {
window.wanakana.bind(this.query);
this.setQuery(window.wanakana.toKana(query));
@ -77,8 +78,6 @@ class DisplaySearch extends Display {
});
}
const query = DisplaySearch.getSearchQueryFromLocation(window.location.href);
if (query !== null) {
if (this.isWanakanaEnabled()) {
this.setQuery(window.wanakana.toKana(query));
} else {
@ -86,7 +85,6 @@ class DisplaySearch extends Display {
}
this.onSearchQueryUpdated(this.query.value, false);
}
}
if (this.clipboardMonitorEnable !== null) {
if (this.options.general.enableClipboardMonitor === true) {
this.clipboardMonitorEnable.checked = true;
@ -162,14 +160,13 @@ class DisplaySearch extends Display {
}
onPopState() {
const query = DisplaySearch.getSearchQueryFromLocation(window.location.href) || '';
if (this.query !== null) {
const {query='', mode=''} = DisplaySearch.parseQueryStringFromLocation(window.location.href);
document.documentElement.dataset.searchMode = mode;
if (this.isWanakanaEnabled()) {
this.setQuery(window.wanakana.toKana(query));
} else {
this.setQuery(query);
}
}
this.onSearchQueryUpdated(this.query.value, false);
}
@ -334,9 +331,11 @@ class DisplaySearch extends Display {
}
}
static getSearchQueryFromLocation(url) {
const match = /^[^?#]*\?(?:[^&#]*&)?query=([^&#]*)/.exec(url);
return match !== null ? decodeURIComponent(match[1]) : null;
static parseQueryStringFromLocation(url) {
const parsedUrl = new URL(url);
const parsedSearch = new URLSearchParams(parsedUrl.search);
return Array.from(parsedSearch.entries())
.reduce((a, [k, v]) => Object.assign({}, a, {[k]: v}), {});
}
}

2
ext/bg/search.html
View File

@ -25,6 +25,7 @@
<p style="margin-bottom: 0;">Search your installed dictionaries by entering a Japanese expression into the field below.</p>
</div>
<div class="search-input">
<div class="input-group" style="padding-top: 20px;">
<span title="Enable kana input method" class="input-group-text">
<input type="checkbox" id="wanakana-enable" class="icon-checkbox" />
@ -42,6 +43,7 @@
<input type="submit" class="btn btn-default form-control" id="search" value="Search">
</span>
</form>
</div>
<div id="spinner" hidden><img src="/mixed/img/spinner.gif"></div>

4
ext/mixed/css/display.css
View File

@ -136,6 +136,10 @@ html:root[data-yomichan-page=float] .navigation-header:not([hidden])~.navigation
margin-right: 0.2em;
}
html:root[data-yomichan-page=search][data-search-mode=popup] .search-input {
display: none;
}
/*
* Entries