alex/yomichan
1
Fork 0
Code Releases Activity

Omit the sound tag if it's empty (#525)

Browse Source
This commit is contained in:
toasted-nutbread 2020-05-09 12:29:41 -04:00 committed by GitHub
parent 9900291b07
commit bdbe680f5c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ext/bg/data/default-anki-field-templates.handlebars
View File

@ -14,9 +14,11 @@
{{~/if~}} {{~/if~}}
{{/inline}} {{/inline}}
{{#*inline "audio"~}} {{#*inline "audio"}}
[sound:{{definition.audioFileName}}] {{~#if definition.audioFileName~}}
{{~/inline}} [sound:{{definition.audioFileName}}]
{{~/if~}}
{{/inline}}
{{#*inline "character"}} {{#*inline "character"}}
{{~definition.character~}} {{~definition.character~}}

2
ext/bg/js/options.js
View File

@ -115,7 +115,7 @@ const profileOptionsVersionUpdates = [
let fieldTemplates = options.anki.fieldTemplates; let fieldTemplates = options.anki.fieldTemplates;
if (typeof fieldTemplates !== 'string') { return; } if (typeof fieldTemplates !== 'string') { return; }
const replacement = '{{#*inline "audio"~}}\n [sound:{{definition.audioFileName}}]\n{{~/inline}}'; const replacement = '{{#*inline "audio"}}\n {{~#if definition.audioFileName~}}\n [sound:{{definition.audioFileName}}]\n {{~/if~}}\n{{/inline}}';
let replaced = false; let replaced = false;
fieldTemplates = fieldTemplates.replace(/\{\{#\*inline "audio"\}\}\{\{\/inline\}\}/g, () => { fieldTemplates = fieldTemplates.replace(/\{\{#\*inline "audio"\}\}\{\{\/inline\}\}/g, () => {
replaced = true; replaced = true;