From bb37b74288cf0653f42bbb149e3c563adcf2ead5 Mon Sep 17 00:00:00 2001
From: toasted-nutbread <toasted-nutbread@users.noreply.github.com>
Date: Thu, 9 Apr 2020 22:19:58 -0400
Subject: [PATCH] Rename "only" to "disambiguation" to match naming convention
 used for pitch accents

---
 ext/mixed/css/display.css         | 10 +++++-----
 ext/mixed/display-templates.html  |  4 ++--
 ext/mixed/js/display-generator.js | 12 ++++++------
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/ext/mixed/css/display.css b/ext/mixed/css/display.css
index ac17e2ec..e10c9379 100644
--- a/ext/mixed/css/display.css
+++ b/ext/mixed/css/display.css
@@ -365,19 +365,19 @@ button.action-button {
     list-style-type: circle;
 }
 
-.term-definition-only-list[data-count="0"] {
+.term-definition-disambiguation-list[data-count="0"] {
     display: none;
 }
 
-.term-definition-only-list:before {
+.term-definition-disambiguation-list:before {
     content: "(";
 }
 
-.term-definition-only-list:after {
+.term-definition-disambiguation-list:after {
     content: " only)";
 }
 
-.term-definition-only+.term-definition-only:before {
+.term-definition-disambiguation+.term-definition-disambiguation:before {
     content: ", ";
 }
 
@@ -399,7 +399,7 @@ button.action-button {
 }
 
 :root[data-compact-glossaries=true] .term-definition-tag-list,
-:root[data-compact-glossaries=true] .term-definition-only-list:not([data-count="0"]) {
+:root[data-compact-glossaries=true] .term-definition-disambiguation-list:not([data-count="0"]) {
     display: inline;
 }
 
diff --git a/ext/mixed/display-templates.html b/ext/mixed/display-templates.html
index b8d52d15..3baa8293 100644
--- a/ext/mixed/display-templates.html
+++ b/ext/mixed/display-templates.html
@@ -30,10 +30,10 @@
 </div></div></template>
 <template id="term-definition-item-template"><li class="term-definition-item">
     <div class="term-definition-tag-list tag-list"></div>
-    <div class="term-definition-only-list"></div>
+    <div class="term-definition-disambiguation-list"></div>
     <ul class="term-glossary-list"></ul>
 </li></template>
-<template id="term-definition-only-template"><span class="term-definition-only"></span></template>
+<template id="term-definition-disambiguation-template"><span class="term-definition-disambiguation"></span></template>
 <template id="term-glossary-item-template"><li class="term-glossary-item"><span class="term-glossary-separator"> </span><span class="term-glossary"></span></li></template>
 <template id="term-reason-template"><span class="term-reason"></span><span class="term-reason-separator"> </span></template>
 
diff --git a/ext/mixed/js/display-generator.js b/ext/mixed/js/display-generator.js
index 5c4b330d..6ae727e0 100644
--- a/ext/mixed/js/display-generator.js
+++ b/ext/mixed/js/display-generator.js
@@ -176,13 +176,13 @@ class DisplayGenerator {
         const node = this._templateHandler.instantiate('term-definition-item');
 
         const tagListContainer = node.querySelector('.term-definition-tag-list');
-        const onlyListContainer = node.querySelector('.term-definition-only-list');
+        const onlyListContainer = node.querySelector('.term-definition-disambiguation-list');
         const glossaryContainer = node.querySelector('.term-glossary-list');
 
         node.dataset.dictionary = details.dictionary;
 
         this._appendMultiple(tagListContainer, this._createTag.bind(this), details.definitionTags);
-        this._appendMultiple(onlyListContainer, this._createTermOnly.bind(this), details.only);
+        this._appendMultiple(onlyListContainer, this._createTermDisambiguation.bind(this), details.only);
         this._appendMultiple(glossaryContainer, this._createTermGlossaryItem.bind(this), details.glossary);
 
         return node;
@@ -197,10 +197,10 @@ class DisplayGenerator {
         return node;
     }
 
-    _createTermOnly(only) {
-        const node = this._templateHandler.instantiate('term-definition-only');
-        node.dataset.only = only;
-        node.textContent = only;
+    _createTermDisambiguation(disambiguation) {
+        const node = this._templateHandler.instantiate('term-definition-disambiguation');
+        node.dataset.term = disambiguation;
+        node.textContent = disambiguation;
         return node;
     }