alex/yomichan
1
Fork 0
Code Releases Activity

fix DOMRect for vertical position calculation (#1986)

Browse Source
This commit is contained in:
Shadowlauch 2021-10-15 01:29:52 +02:00 committed by GitHub
parent 0a8992d215
commit b3d38fce47
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ext/js/app/popup.js
View File

@ -560,16 +560,16 @@ class Popup extends EventDispatcher {
const verticalOffset = optionsGeneral.popupVerticalOffset2 * offsetScale; const verticalOffset = optionsGeneral.popupVerticalOffset2 * offsetScale;
const [x, w] = this._getConstrainedPositionBinary( const [x, w] = this._getConstrainedPositionBinary(
elementRect.left - horizontalOffset, elementRect.x - horizontalOffset,
elementRect.right + horizontalOffset, elementRect.x + elementRect.width + horizontalOffset,
width, width,
viewport.left, viewport.left,
viewport.right, viewport.right,
preferRight preferRight
); );
const [y, h, below] = this._getConstrainedPosition( const [y, h, below] = this._getConstrainedPosition(
elementRect.bottom - verticalOffset, elementRect.y + elementRect.height - verticalOffset,
elementRect.top + verticalOffset, elementRect.y + verticalOffset,
height, height,
viewport.top, viewport.top,
viewport.bottom, viewport.bottom,