From b0bc7dc08fd05fbfc45679fbad9aee82a9f2248e Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Tue, 2 Mar 2021 22:08:34 -0500 Subject: [PATCH] Add a toggle for the persistent storage option on the permissions page (#1479) --- ext/js/pages/permissions-main.js | 4 ++++ ext/permissions.html | 23 +++++++++++++++++++++++ 2 files changed, 27 insertions(+) diff --git a/ext/js/pages/permissions-main.js b/ext/js/pages/permissions-main.js index 782ea9ec..66fa1d42 100644 --- a/ext/js/pages/permissions-main.js +++ b/ext/js/pages/permissions-main.js @@ -18,6 +18,7 @@ /* global * DocumentFocusController * PermissionsToggleController + * PersistentStorageController * SettingsController */ @@ -92,6 +93,9 @@ function setupPermissionsToggles() { const permissionsToggleController = new PermissionsToggleController(settingsController); permissionsToggleController.prepare(); + const persistentStorageController = new PersistentStorageController(); + persistentStorageController.prepare(); + await promiseTimeout(100); document.documentElement.dataset.loaded = 'true'; diff --git a/ext/permissions.html b/ext/permissions.html index 5bd6987f..699aca4f 100644 --- a/ext/permissions.html +++ b/ext/permissions.html @@ -153,6 +153,28 @@ +
+
+
Persistent storage
+
+

+ Web browsers will sometimes clear stored data if the device is running low on storage space, + which can result in the imported dictionaries being deleted unexpectedly. + The persistent storage permission tells the browser that the data should not be deleted in those circumstances. +

+

+ It may not be possible to enable this permission on Firefox for Android. +

+

+ Chromium-based browsers should not need to enable this setting since the Yomichan extension has + the unlimitedStorage permission, which should prevent data deletion.[1] +

+
+
+
+ +
+
@@ -172,6 +194,7 @@ +