alex/yomichan
1
Fork 0
Code Releases Activity

Make Display.authenticateMessageData private (#1780)

Browse Source
This commit is contained in:
toasted-nutbread 2021-06-29 22:17:14 -04:00 committed by GitHub
parent deb2a742ed
commit ace46503be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ext/js/display/display.js
View File

@ -380,16 +380,6 @@ class Display extends EventDispatcher {
} }
} }
authenticateMessageData(data) {
if (this._frameEndpoint === null) {
return data;
}
if (!this._frameEndpoint.authenticate(data)) {
throw new Error('Invalid authentication');
}
return data.data;
}
setQueryPostProcessor(func) { setQueryPostProcessor(func) {
this._queryPostProcessor = func; this._queryPostProcessor = func;
} }
@ -454,7 +444,7 @@ class Display extends EventDispatcher {
// Message handlers // Message handlers
_onDirectMessage(data) { _onDirectMessage(data) {
data = this.authenticateMessageData(data); data = this._authenticateMessageData(data);
const {action, params} = data; const {action, params} = data;
const handlerInfo = this._directMessageHandlers.get(action); const handlerInfo = this._directMessageHandlers.get(action);
if (typeof handlerInfo === 'undefined') { if (typeof handlerInfo === 'undefined') {
@ -468,7 +458,7 @@ class Display extends EventDispatcher {
_onWindowMessage({data}) { _onWindowMessage({data}) {
try { try {
data = this.authenticateMessageData(data); data = this._authenticateMessageData(data);
} catch (e) { } catch (e) {
return; return;
} }
@ -518,6 +508,16 @@ class Display extends EventDispatcher {
// Private // Private
_authenticateMessageData(data) {
if (this._frameEndpoint === null) {
return data;
}
if (!this._frameEndpoint.authenticate(data)) {
throw new Error('Invalid authentication');
}
return data.data;
}
async _onStateChanged() { async _onStateChanged() {
if (this._historyChangeIgnore) { return; } if (this._historyChangeIgnore) { return; }