alex/yomichan
1
Fork 0
Code Releases Activity

Safely handle volume values that are out of range (#617)

Browse Source
This commit is contained in:
toasted-nutbread 2020-06-21 15:51:36 -04:00 committed by GitHub
parent 713bf29377
commit 9e28db6ef7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ext/mixed/js/display.js
View File

@ -807,9 +807,10 @@ class Display {
this._stopPlayingAudio(); this._stopPlayingAudio();
const volume = Math.max(0.0, Math.min(1.0, this.options.audio.volume / 100.0));
this.audioPlaying = audio; this.audioPlaying = audio;
audio.currentTime = 0; audio.currentTime = 0;
audio.volume = this.options.audio.volume / 100.0; audio.volume = Number.isFinite(volume) ? volume : 1.0;
const playPromise = audio.play(); const playPromise = audio.play();
if (typeof playPromise !== 'undefined') { if (typeof playPromise !== 'undefined') {
try { try {