alex/yomichan
1
Fork 0
Code Releases Activity

Update audio controller for menus (#936)

Browse Source 
* Make event non-async

* Only add event listener if the button exists

* Add support for menu for removal
This commit is contained in:
toasted-nutbread 2020-10-18 13:18:57 -04:00 committed by GitHub
parent 3ab63f4f55
commit 988ea8f70a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
ext/bg/js/settings/audio-controller.js
View File

@ -155,6 +155,7 @@ class AudioController {
const container = this._settingsController.instantiateTemplate('audio-source'); const container = this._settingsController.instantiateTemplate('audio-source');
const select = container.querySelector('.audio-source-select'); const select = container.querySelector('.audio-source-select');
const removeButton = container.querySelector('.audio-source-remove'); const removeButton = container.querySelector('.audio-source-remove');
const menuButton = container.querySelector('.audio-source-menu-button');
select.value = value; select.value = value;
@ -165,7 +166,12 @@ class AudioController {
}; };
eventListeners.addEventListener(select, 'change', this._onAudioSourceSelectChange.bind(this, entry), false); eventListeners.addEventListener(select, 'change', this._onAudioSourceSelectChange.bind(this, entry), false);
eventListeners.addEventListener(removeButton, 'click', this._onAudioSourceRemoveClicked.bind(this, entry), false); if (removeButton !== null) {
eventListeners.addEventListener(removeButton, 'click', this._onAudioSourceRemoveClicked.bind(this, entry), false);
}
if (menuButton !== null) {
eventListeners.addEventListener(menuButton, 'menuClosed', this._onMenuClosed.bind(this, entry), false);
}
this._audioSourceContainer.appendChild(container); this._audioSourceContainer.appendChild(container);
this._audioSourceEntries.push(entry); this._audioSourceEntries.push(entry);
@ -216,7 +222,16 @@ class AudioController {
await this._settingsController.setProfileSetting(`audio.sources[${index}]`, value); await this._settingsController.setProfileSetting(`audio.sources[${index}]`, value);
} }
async _onAudioSourceRemoveClicked(entry) { _onAudioSourceRemoveClicked(entry) {
await this._removeAudioSourceEntry(entry); this._removeAudioSourceEntry(entry);
}
_onMenuClosed(entry, e) {
const {detail: {action}} = e;
switch (action) {
case 'remove':
this._removeAudioSourceEntry(entry);
break;
}
} }
} }