alex/yomichan
1
Fork 0
Code Releases Activity

Popup proxy improvements (#764)

Browse Source 
* Fix incorrect function invocations

* Ignore setVisibleOverride when it returns null

* Omit redundant async

* Change default return value
This commit is contained in:
toasted-nutbread 2020-09-04 17:58:43 -04:00 committed by GitHub
parent 8d53474945
commit 95bfe2d901
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ext/fg/js/popup-factory.js
View File

@ -122,7 +122,7 @@ class PopupFactory {
promises.push(promise); promises.push(promise);
} }
const results = await Promise.all(promises); const results = (await Promise.all(promises)).filter(({token}) => token !== null);
if (errors.length === 0) { if (errors.length === 0) {
const token = generateId(16); const token = generateId(16);

14
ext/fg/js/popup-proxy.js
View File

@ -86,12 +86,12 @@ class PopupProxy extends EventDispatcher {
return this._invokeSafe('isVisible', {id: this._id}, false); return this._invokeSafe('isVisible', {id: this._id}, false);
} }
async setVisibleOverride(value, priority) { setVisibleOverride(value, priority) {
return this._invokeSafe('setVisibleOverride', {id: this._id, value, priority}); return this._invokeSafe('setVisibleOverride', {id: this._id, value, priority}, null);
} }
async clearVisibleOverride(token) { clearVisibleOverride(token) {
return this._invokeSafe('clearVisibleOverride', {id: this._id, token}); return this._invokeSafe('clearVisibleOverride', {id: this._id, token}, false);
} }
async containsPoint(x, y) { async containsPoint(x, y) {
@ -135,12 +135,12 @@ class PopupProxy extends EventDispatcher {
return this._invokeSafe('updateTheme', {id: this._id}); return this._invokeSafe('updateTheme', {id: this._id});
} }
async setCustomOuterCss(css, useWebExtensionApi) { setCustomOuterCss(css, useWebExtensionApi) {
return this._invokeSafe('updateTheme', {id: this._id, css, useWebExtensionApi}); return this._invokeSafe('setCustomOuterCss', {id: this._id, css, useWebExtensionApi});
} }
setChildrenSupported(value) { setChildrenSupported(value) {
return this._invokeSafe('updateTheme', {id: this._id, value}); return this._invokeSafe('setChildrenSupported', {id: this._id, value});
} }
getFrameRect() { getFrameRect() {