alex/yomichan
1
Fork 0
Code Releases Activity

focus and scroll to input only when it's needed

Browse Source
This commit is contained in:
siikamiika 2019-10-26 14:30:36 +03:00
parent fe8eb76928
commit 9132814ccf
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ext/bg/js/search.js
View File

@ -79,7 +79,11 @@ class DisplaySearch extends Display {
onSearchInput() { onSearchInput() {
this.updateSearchButton(); this.updateSearchButton();
this.query.scrollIntoView();
const queryElementRect = this.query.getBoundingClientRect();
if (queryElementRect.top < 0 || queryElementRect.bottom > window.innerHeight) {
this.query.scrollIntoView();
}
} }
onSearch(e) { onSearch(e) {
@ -123,7 +127,7 @@ class DisplaySearch extends Display {
} }
} }
if (!super.onKeyDown(e) && !preventFocus) { if (!super.onKeyDown(e) && !preventFocus && document.activeElement !== this.query) {
this.query.focus({preventScroll: true}); this.query.focus({preventScroll: true});
} }
} }