workaround for broken const in firefox

This commit is contained in:
Alex Yatskov 2017-01-28 18:46:15 -08:00
parent bf9925ec9c
commit 8efe5b1fbf
7 changed files with 42 additions and 42 deletions

View File

@ -87,7 +87,7 @@ class Database {
}).then(() => {
return this.cacheTagMeta(dictionaries);
}).then(() => {
for (const result of results) {
for (let result of results) {
result.tagMeta = this.tagMetaCache[result.dictionary] || {};
}
@ -115,7 +115,7 @@ class Database {
}).then(() => {
return this.cacheTagMeta(dictionaries);
}).then(() => {
for (const result of results) {
for (let result of results) {
result.tagMeta = this.tagMetaCache[result.dictionary] || {};
}
@ -129,7 +129,7 @@ class Database {
}
const promises = [];
for (const dictionary of dictionaries) {
for (let dictionary of dictionaries) {
if (this.tagMetaCache[dictionary]) {
continue;
}
@ -246,7 +246,7 @@ class Database {
return this.db.dictionaries.add({title, version, revision, hasTerms, hasKanji}).then(() => {
const rows = [];
for (const tag in tagMeta || {}) {
for (let tag in tagMeta || {}) {
const meta = tagMeta[tag];
const row = sanitizeTag({
name: tag,
@ -266,7 +266,7 @@ class Database {
const termsLoaded = (title, entries, total, current) => {
const rows = [];
for (const [expression, reading, tags, rules, score, ...glossary] of entries) {
for (let [expression, reading, tags, rules, score, ...glossary] of entries) {
rows.push({
expression,
reading,
@ -287,7 +287,7 @@ class Database {
const kanjiLoaded = (title, entries, total, current) => {
const rows = [];
for (const [character, onyomi, kunyomi, tags, ...meanings] of entries) {
for (let [character, onyomi, kunyomi, tags, ...meanings] of entries) {
rows.push({
character,
onyomi,

View File

@ -32,8 +32,8 @@ class Deinflection {
if (this.rules.length === 0) {
this.definitions = definitions;
} else {
for (const rule of this.rules) {
for (const definition of definitions) {
for (let rule of this.rules) {
for (let definition of definitions) {
if (definition.rules.includes(rule)) {
this.definitions.push(definition);
}
@ -46,11 +46,11 @@ class Deinflection {
};
const promises = [];
for (const reason in reasons) {
for (const variant of reasons[reason]) {
for (let reason in reasons) {
for (let variant of reasons[reason]) {
let accept = this.rules.length === 0;
if (!accept) {
for (const rule of this.rules) {
for (let rule of this.rules) {
if (variant.rulesIn.includes(rule)) {
accept = true;
break;
@ -95,8 +95,8 @@ class Deinflection {
}
const results = [];
for (const child of this.children) {
for (const result of child.gather()) {
for (let child of this.children) {
for (let result of child.gather()) {
if (this.reason.length > 0) {
result.reasons.push(this.reason);
}

View File

@ -48,7 +48,7 @@ function optionsSetDefaults(options) {
};
const combine = (target, source) => {
for (const key in source) {
for (let key in source) {
if (!(key in target)) {
target[key] = source[key];
}
@ -104,8 +104,8 @@ function optionsVersion(options) {
'{glossary-list}': '{glossary}'
};
for (const name in fields) {
for (const fixup in fixups) {
for (let name in fields) {
for (let fixup in fixups) {
fields[name] = fields[name].replace(fixup, fixups[fixup]);
}
}
@ -114,7 +114,7 @@ function optionsVersion(options) {
fixupFields(options.anki.terms.fields);
fixupFields(options.anki.kanji.fields);
for (const title in options.dictionaries) {
for (let title in options.dictionaries) {
const dictionary = options.dictionaries[title];
dictionary.enabled = dictionary.enableTerms || dictionary.enableKanji;
dictionary.priority = 0;
@ -127,8 +127,8 @@ function optionsVersion(options) {
'{glossary-list}': '{glossary}'
};
for (const name in fields) {
for (const fixup in fixups) {
for (let name in fields) {
for (let fixup in fixups) {
fields[name] = fields[name].replace(fixup, fixups[fixup]);
}
}

View File

@ -54,8 +54,8 @@ class Translator {
}
}).then(deinflections => {
let definitions = [];
for (const deinflection of deinflections) {
for (const definition of deinflection.definitions) {
for (let deinflection of deinflections) {
for (let definition of deinflection.definitions) {
const tags = definition.tags.map(tag => buildTag(tag, definition.tagMeta));
tags.push(buildDictTag(definition.dictionary));
definitions.push({
@ -76,7 +76,7 @@ class Translator {
definitions = sortTermDefs(definitions, dictionaries);
let length = 0;
for (const definition of definitions) {
for (let definition of definitions) {
length = Math.max(length, definition.source.length);
}
@ -95,7 +95,7 @@ class Translator {
const processed = {};
const promises = [];
for (const c of text) {
for (let c of text) {
if (!processed[c]) {
promises.push(this.database.findKanji(c, titles));
processed[c] = true;
@ -104,7 +104,7 @@ class Translator {
return Promise.all(promises).then(defSets => {
const definitions = defSets.reduce((a, b) => a.concat(b), []);
for (const definition of definitions) {
for (let definition of definitions) {
const tags = definition.tags.map(tag => buildTag(tag, definition.tagMeta));
tags.push(buildDictTag(definition.dictionary));
definition.tags = sortTags(tags);
@ -130,7 +130,7 @@ class Translator {
return Promise.all(promises).then(results => {
let deinflections = [];
for (const result of results) {
for (let result of results) {
deinflections = deinflections.concat(result);
}
@ -139,7 +139,7 @@ class Translator {
}
processKanji(definitions) {
for (const definition of definitions) {
for (let definition of definitions) {
const tags = definition.tags.map(tag => buildTag(tag, definition.tagMeta));
definition.tags = sortTags(tags);
}

View File

@ -19,7 +19,7 @@
function kanjiLinks(options) {
let result = '';
for (const c of options.fn(this)) {
for (let c of options.fn(this)) {
if (isKanji(c)) {
result += `<a href="#" class="kanji-link">${c}</a>`;
} else {
@ -41,7 +41,7 @@ function isKanji(c) {
function enabledDicts(options) {
const dictionaries = {};
for (const title in options.dictionaries) {
for (let title in options.dictionaries) {
const dictionary = options.dictionaries[title];
if (dictionary.enabled) {
dictionaries[title] = dictionary;
@ -104,7 +104,7 @@ function sortTermDefs(definitions, dictionaries=null) {
function undupeTermDefs(definitions) {
const definitionGroups = {};
for (const definition of definitions) {
for (let definition of definitions) {
const definitionExisting = definitionGroups[definition.id];
if (!definitionGroups.hasOwnProperty(definition.id) || definition.expression.length > definitionExisting.expression.length) {
definitionGroups[definition.id] = definition;
@ -112,7 +112,7 @@ function undupeTermDefs(definitions) {
}
const definitionsUnique = [];
for (const key in definitionGroups) {
for (let key in definitionGroups) {
definitionsUnique.push(definitionGroups[key]);
}
@ -121,7 +121,7 @@ function undupeTermDefs(definitions) {
function groupTermDefs(definitions, dictionaries) {
const groups = {};
for (const definition of definitions) {
for (let definition of definitions) {
const key = [definition.source, definition.expression].concat(definition.reasons);
if (definition.reading) {
key.push(definition.reading);
@ -136,7 +136,7 @@ function groupTermDefs(definitions, dictionaries) {
}
const results = [];
for (const key in groups) {
for (let key in groups) {
const groupDefs = groups[key];
const firstDef = groupDefs[0];
sortTermDefs(groupDefs, dictionaries);
@ -160,7 +160,7 @@ function buildDictTag(name) {
function buildTag(name, meta) {
const tag = {name};
const symbol = name.split(':')[0];
for (const prop in meta[symbol] || {}) {
for (let prop in meta[symbol] || {}) {
tag[prop] = meta[symbol][prop];
}
@ -217,7 +217,7 @@ function formatField(field, definition, mode, options) {
'url'
];
for (const marker of markers) {
for (let marker of markers) {
const data = {
marker,
definition,
@ -303,7 +303,7 @@ function importJsonDb(indexUrl, indexLoaded, termsLoaded, kanjiLoaded) {
}
let chain = Promise.resolve();
for (const loader of loaders) {
for (let loader of loaders) {
chain = chain.then(loader);
}

View File

@ -81,7 +81,7 @@ class Yomichan {
tabInvokeAll(action, params) {
chrome.tabs.query({}, tabs => {
for (const tab of tabs) {
for (let tab of tabs) {
chrome.tabs.sendMessage(tab.id, {action, params}, () => null);
}
});
@ -106,7 +106,7 @@ class Yomichan {
fields: []
};
for (const name in fields) {
for (let name in fields) {
if (fields[name].includes('{audio}')) {
audio.fields.push(name);
}
@ -117,7 +117,7 @@ class Yomichan {
}
}
for (const name in fields) {
for (let name in fields) {
note.fields[name] = formatField(
fields[name],
definition,
@ -175,8 +175,8 @@ class Yomichan {
api_canAddDefinitions({definitions, modes, callback}) {
const notes = [];
for (const definition of definitions) {
for (const mode of modes) {
for (let definition of definitions) {
for (let mode of modes) {
notes.push(this.formatNote(definition, mode));
}
}

View File

@ -118,7 +118,7 @@ class Frame {
}
states.forEach((state, index) => {
for (const mode in state) {
for (let mode in state) {
const button = this.findAddNoteButton(index, mode);
if (state[mode]) {
button.removeClass('disabled');
@ -147,7 +147,7 @@ class Frame {
url += `&kana=${encodeURIComponent(definition.reading)}`;
}
for (const key in this.audioCache) {
for (let key in this.audioCache) {
this.audioCache[key].pause();
}