alex/yomichan
1
Fork 0
Code Releases Activity

Remove uniqueness check for requirements (#1790)

Browse Source
This commit is contained in:
toasted-nutbread 2021-07-03 11:35:03 -04:00 committed by GitHub
parent f7d177e6d0
commit 82b7ebfa58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ext/js/templates/template-renderer.js
View File

@ -32,7 +32,6 @@ class TemplateRenderer {
this._dataTypes = new Map(); this._dataTypes = new Map();
this._requirements = null; this._requirements = null;
this._cleanupCallbacks = null; this._cleanupCallbacks = null;
this._customData = null;
this._temporaryElement = null; this._temporaryElement = null;
} }
@ -93,7 +92,6 @@ class TemplateRenderer {
const cleanupCallbacks = []; const cleanupCallbacks = [];
const requirements = []; const requirements = [];
try { try {
this._customData = {};
this._stateStack = [new Map()]; this._stateStack = [new Map()];
this._requirements = requirements; this._requirements = requirements;
this._cleanupCallbacks = cleanupCallbacks; this._cleanupCallbacks = cleanupCallbacks;
@ -104,7 +102,6 @@ class TemplateRenderer {
this._stateStack = null; this._stateStack = null;
this._requirements = null; this._requirements = null;
this._cleanupCallbacks = null; this._cleanupCallbacks = null;
this._customData = null;
} }
} }
@ -588,20 +585,11 @@ class TemplateRenderer {
onLoad(imageUrl); onLoad(imageUrl);
this._cleanupCallbacks.push(() => onUnload(true)); this._cleanupCallbacks.push(() => onUnload(true));
} else { } else {
let set = this._customData.requiredDictionaryMedia; this._requirements.push({
if (typeof set === 'undefined') { type: 'dictionaryMedia',
set = new Set(); dictionary,
this._customData.requiredDictionaryMedia = set; path
} });
const key = JSON.stringify([dictionary, path]);
if (!set.has(key)) {
set.add(key);
this._requirements.push({
type: 'dictionaryMedia',
dictionary,
path
});
}
} }
} }
}; };