From 7c06a224514ed4288122160bfac84f9ae7521897 Mon Sep 17 00:00:00 2001 From: Alex Yatskov Date: Sun, 22 May 2016 13:41:52 -0700 Subject: [PATCH] Field selector working --- ext/bg/js/options-form.js | 49 ++++++++++++++++++++++++++++++++------- ext/bg/js/yomichan.js | 4 ++-- ext/bg/options.html | 8 +++---- 3 files changed, 46 insertions(+), 15 deletions(-) diff --git a/ext/bg/js/options-form.js b/ext/bg/js/options-form.js index 31756486..06be044a 100644 --- a/ext/bg/js/options-form.js +++ b/ext/bg/js/options-form.js @@ -17,6 +17,10 @@ */ +function yomichan() { + return chrome.extension.getBackgroundPage().yomichan; +} + function optionsToForm(opts) { $('#activateOnStartup').prop('checked', opts.activateOnStartup); $('#enableAnkiConnect').prop('checked', opts.enableAnkiConnect); @@ -35,21 +39,21 @@ function formToOptions() { }); } -function updateAnkiFormDataVis(opts) { +function updateAnkiFormVis(opts) { if (opts.enableAnkiConnect) { - updateAnkiFormData(); + populateAnkiDeckAndModel(); $('.options-anki').fadeIn(); } else { $('.options-anki').fadeOut(); } } -function updateAnkiFormData() { - const yomichan = chrome.extension.getBackgroundPage().yomichan; +function populateAnkiDeckAndModel() { + const yomi = yomichan(); const ankiDeck = $('.ankiDeck'); ankiDeck.find('option').remove(); - yomichan.api_getDeckNames({callback: (names) => { + yomi.api_getDeckNames({callback: (names) => { if (names !== null) { names.forEach((name) => ankiDeck.append($('