alex/yomichan
1
Fork 0
Code Releases Activity

Don't clear the selection before the text scanner has been enabled (#2006)

Browse Source
This commit is contained in:
toasted-nutbread 2021-11-13 11:11:33 -05:00 committed by GitHub
parent 657292733d
commit 70ac6c51f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ext/js/app/frontend.js
View File

@ -83,6 +83,7 @@ class Frontend {
searchTerms: true, searchTerms: true,
searchKanji: true searchKanji: true
}); });
this._textScannerHasBeenEnabled = false;
this._popupCache = new Map(); this._popupCache = new Map();
this._popupEventListeners = new EventListenerCollection(); this._popupEventListeners = new EventListenerCollection();
this._updatePopupToken = null; this._updatePopupToken = null;
@ -620,8 +621,13 @@ class Frontend {
const enabled = (this._options !== null && this._options.general.enable && !this._disabledOverride); const enabled = (this._options !== null && this._options.general.enable && !this._disabledOverride);
if (enabled === this._textScanner.isEnabled()) { return; } if (enabled === this._textScanner.isEnabled()) { return; }
this._textScanner.setEnabled(enabled); this._textScanner.setEnabled(enabled);
if (this._textScannerHasBeenEnabled) {
this._clearSelection(true); this._clearSelection(true);
} }
if (enabled) {
this._textScannerHasBeenEnabled = true;
}
}
_updateContentScale() { _updateContentScale() {
const {popupScalingFactor, popupScaleRelativeToPageZoom, popupScaleRelativeToVisualViewport} = this._options.general; const {popupScalingFactor, popupScaleRelativeToPageZoom, popupScaleRelativeToVisualViewport} = this._options.general;