alex/yomichan
1
Fork 0
Code Releases Activity

block placeholder audio with a short audio clip

Browse Source
This commit is contained in:
Alex Yatskov 2017-02-11 12:16:14 -08:00
parent 7398e74d71
commit 701c91ea66
3 changed files with 22 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
ext/fg/js/frame.js
View File

@ -170,12 +170,27 @@ class Frame {
} }
for (const key in this.audioCache) { for (const key in this.audioCache) {
this.audioCache[key].pause(); const audio = this.audioCache[key];
if (audio !== null) {
audio.pause();
}
} }
const audio = this.audioCache[url] || new Audio(url); let audio = this.audioCache[url];
audio.currentTime = 0; if (audio) {
audio.play(); audio.currentTime = 0;
audio.play();
} else {
audio = new Audio(url);
audio.onloadeddata = () => {
if (audio.duration === 5.694694) {
audio = new Audio('mp3/button.mp3');
}
this.audioCache[url] = audio;
audio.play();
};
}
} }
handleError(error) { handleError(error) {

BIN
ext/fg/mp3/button.mp3 Normal file
View File

Binary file not shown.

5
ext/manifest.json
View File

@ -1,7 +1,7 @@
{ {
"manifest_version": 2, "manifest_version": 2,
"name": "Yomichan", "name": "Yomichan",
"version": "1.0.12", "version": "1.0.13",
"description": "Japanese dictionary with Anki integration", "description": "Japanese dictionary with Anki integration",
"icons": {"16": "img/icon16.png", "48": "img/icon48.png", "128": "img/icon128.png"}, "icons": {"16": "img/icon16.png", "48": "img/icon48.png", "128": "img/icon128.png"},
@ -31,13 +31,14 @@
], ],
"web_accessible_resources": [ "web_accessible_resources": [
"fg/css/frame.css", "fg/css/frame.css",
"fg/frame.html",
"fg/img/add_kanji.png", "fg/img/add_kanji.png",
"fg/img/add_term_kana.png", "fg/img/add_term_kana.png",
"fg/img/add_term_kanji.png", "fg/img/add_term_kanji.png",
"fg/img/play_audio.png", "fg/img/play_audio.png",
"fg/img/spinner.gif", "fg/img/spinner.gif",
"fg/js/frame.js", "fg/js/frame.js",
"fg/frame.html", "fg/mp3/button.mp3",
"fg/ttf/kanji-stroke-orders.ttf", "fg/ttf/kanji-stroke-orders.ttf",
"fg/ttf/vl-gothic-regular.ttf" "fg/ttf/vl-gothic-regular.ttf"
] ]