alex/yomichan
1
Fork 0
Code Releases Activity

Make PopupFactory.prepare non-async (#625)

Browse Source
This commit is contained in:
toasted-nutbread 2020-06-25 18:32:29 -04:00 committed by GitHub
parent 3e68af8666
commit 6ee50b3c95
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ext/bg/js/search.js
View File

@ -438,7 +438,7 @@ class DisplaySearch extends Display {
const {frameId} = await api.frameInformationGet(); const {frameId} = await api.frameInformationGet();
const popupFactory = new PopupFactory(frameId); const popupFactory = new PopupFactory(frameId);
await popupFactory.prepare(); popupFactory.prepare();
const frontend = new Frontend( const frontend = new Frontend(
frameId, frameId,

2
ext/bg/js/settings/popup-preview-frame-main.js
View File

@ -28,7 +28,7 @@
const {frameId} = await api.frameInformationGet(); const {frameId} = await api.frameInformationGet();
const popupFactory = new PopupFactory(frameId); const popupFactory = new PopupFactory(frameId);
await popupFactory.prepare(); popupFactory.prepare();
const preview = new PopupPreviewFrame(frameId, popupFactory); const preview = new PopupPreviewFrame(frameId, popupFactory);
await preview.prepare(); await preview.prepare();

2
ext/fg/js/content-script-main.js
View File

@ -32,7 +32,7 @@
} }
const popupFactory = new PopupFactory(frameId); const popupFactory = new PopupFactory(frameId);
await popupFactory.prepare(); popupFactory.prepare();
const frontend = new Frontend( const frontend = new Frontend(
frameId, frameId,

2
ext/fg/js/float.js
View File

@ -241,7 +241,7 @@ class DisplayFloat extends Display {
const {frameId} = await api.frameInformationGet(); const {frameId} = await api.frameInformationGet();
const popupFactory = new PopupFactory(frameId); const popupFactory = new PopupFactory(frameId);
await popupFactory.prepare(); popupFactory.prepare();
const frontend = new Frontend( const frontend = new Frontend(
frameId, frameId,

2
ext/fg/js/popup-factory.js
View File

@ -28,7 +28,7 @@ class PopupFactory {
// Public functions // Public functions
async prepare() { prepare() {
api.crossFrame.registerHandlers([ api.crossFrame.registerHandlers([
['getOrCreatePopup', {async: false, handler: this._onApiGetOrCreatePopup.bind(this)}], ['getOrCreatePopup', {async: false, handler: this._onApiGetOrCreatePopup.bind(this)}],
['setOptionsContext', {async: true, handler: this._onApiSetOptionsContext.bind(this)}], ['setOptionsContext', {async: true, handler: this._onApiSetOptionsContext.bind(this)}],