alex/yomichan
1
Fork 0
Code Releases Activity

Update merged definitions to have consistent structure (#890)

Browse Source 
* Update comment about definitions type

* Add conversion to ensure consistent data structure
This commit is contained in:
toasted-nutbread 2020-10-06 19:31:53 -04:00 committed by GitHub
parent 7ce87c51b4
commit 69f94f8cb8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ext/bg/js/translator.js
View File

@ -199,7 +199,7 @@ class Translator {
const compatibilityDefinition = this._createMergedTermDefinition( const compatibilityDefinition = this._createMergedTermDefinition(
source, source,
rawSource, rawSource,
definitions2, this._convertTermDefinitionsToMergedGlossaryTermDefinitions(definitions2),
[expression], [expression],
[reading], [reading],
termDetailsList, termDetailsList,
@ -647,6 +647,18 @@ class Translator {
} }
} }
_convertTermDefinitionsToMergedGlossaryTermDefinitions(definitions) {
const convertedDefinitions = [];
for (const definition of definitions) {
const {source, rawSource, expression, reading} = definition;
const expressions = new Set([expression]);
const readings = new Set([reading]);
const convertedDefinition = this._createMergedGlossaryTermDefinition(source, rawSource, [definition], expressions, readings, expressions, readings);
convertedDefinitions.push(convertedDefinition);
}
return convertedDefinitions;
}
// Metadata building // Metadata building
async _buildTermMeta(definitions, enabledDictionaryMap) { async _buildTermMeta(definitions, enabledDictionaryMap) {