Update global declarations

2020-03-10 22:30:36 -04:00 · 2020-03-10 22:30:36 -04:00 · 64fc0349a1
commit 64fc0349a1
parent 5837d273f6
36 changed files with 272 additions and 70 deletions
--- a/.eslintrc.json
+++ b/.eslintrc.json
@ -63,7 +63,7 @@
        "semi-spacing": ["error", {"before": false, "after": true}],
        "space-in-parens": ["error", "never"],
        "space-unary-ops": "error",
-        "spaced-comment": ["error", "always", {"markers": ["global"]}],
+        "spaced-comment": ["error", "always"],
        "switch-colon-spacing": ["error", {"after": true, "before": false}],
        "template-curly-spacing": ["error", "never"],
        "template-tag-spacing": ["error", "never"],
--- a/ext/bg/js/anki.js
+++ b/ext/bg/js/anki.js
@ -16,7 +16,9 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global requestJson*/
+/* global
+ * requestJson
+ */

 /*
 * AnkiConnect
--- a/ext/bg/js/audio-uri-builder.js
+++ b/ext/bg/js/audio-uri-builder.js
@ -16,7 +16,9 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global jpIsStringEntirelyKana*/
+/* global
+ * jpIsStringEntirelyKana
+ */

 class AudioUriBuilder {
    constructor() {
--- a/ext/bg/js/backend.js
+++ b/ext/bg/js/backend.js
@ -16,13 +16,32 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global optionsSave, utilIsolate
-conditionsTestValue, profileConditionsDescriptor
-handlebarsRenderDynamic
-requestText, requestJson, optionsLoad
-dictConfigured, dictTermsSort, dictEnabledSet
-jpConvertReading, jpDistributeFuriganaInflected, jpKatakanaToHiragana
-AnkiNoteBuilder, AudioSystem, AudioUriBuilder, Translator, AnkiConnect, AnkiNull, Mecab, BackendApiForwarder, JsonSchema, ClipboardMonitor*/
+/* global
+ * AnkiConnect
+ * AnkiNoteBuilder
+ * AnkiNull
+ * AudioSystem
+ * AudioUriBuilder
+ * BackendApiForwarder
+ * ClipboardMonitor
+ * JsonSchema
+ * Mecab
+ * Translator
+ * conditionsTestValue
+ * dictConfigured
+ * dictEnabledSet
+ * dictTermsSort
+ * handlebarsRenderDynamic
+ * jpConvertReading
+ * jpDistributeFuriganaInflected
+ * jpKatakanaToHiragana
+ * optionsLoad
+ * optionsSave
+ * profileConditionsDescriptor
+ * requestJson
+ * requestText
+ * utilIsolate
+ */

 class Backend {
    constructor() {
--- a/ext/bg/js/clipboard-monitor.js
+++ b/ext/bg/js/clipboard-monitor.js
@ -16,7 +16,9 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global jpIsStringPartiallyJapanese*/
+/* global
+ * jpIsStringPartiallyJapanese
+ */

 class ClipboardMonitor extends EventDispatcher {
    constructor({getClipboard}) {
--- a/ext/bg/js/context.js
+++ b/ext/bg/js/context.js
@ -16,7 +16,11 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiCommandExec, apiGetEnvironmentInfo, apiOptionsGet*/
+/* global
+ * apiCommandExec
+ * apiGetEnvironmentInfo
+ * apiOptionsGet
+ */

 function showExtensionInfo() {
    const node = document.getElementById('extension-info');
--- a/ext/bg/js/database.js
+++ b/ext/bg/js/database.js
@ -16,7 +16,12 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global dictFieldSplit, requestJson, JsonSchema, JSZip*/
+/* global
+ * JSZip
+ * JsonSchema
+ * dictFieldSplit
+ * requestJson
+ */

 class Database {
    constructor() {
--- a/ext/bg/js/handlebars.js
+++ b/ext/bg/js/handlebars.js
@ -16,7 +16,11 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global jpIsCodePointKanji, jpDistributeFurigana, Handlebars*/
+/* global
+ * Handlebars
+ * jpDistributeFurigana
+ * jpIsCodePointKanji
+ */

 function handlebarsEscape(text) {
    return Handlebars.Utils.escapeExpression(text);
--- a/ext/bg/js/japanese.js
+++ b/ext/bg/js/japanese.js
@ -16,7 +16,9 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global wanakana*/
+/* global
+ * wanakana
+ */

 const JP_HALFWIDTH_KATAKANA_MAPPING = new Map([
    ['ｦ', 'ヲヺ-'],
--- a/ext/bg/js/options.js
+++ b/ext/bg/js/options.js
@ -16,7 +16,9 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global utilStringHashCode*/
+/* global
+ * utilStringHashCode
+ */

 /*
 * Generic options functions
--- a/ext/bg/js/search-frontend.js
+++ b/ext/bg/js/search-frontend.js
@ -16,7 +16,9 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiOptionsGet*/
+/* global
+ * apiOptionsGet
+ */

 async function searchFrontendSetup() {
    await yomichan.prepare();
--- a/ext/bg/js/search-query-parser-generator.js
+++ b/ext/bg/js/search-query-parser-generator.js
@ -16,7 +16,10 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiGetQueryParserTemplatesHtml, TemplateHandler*/
+/* global
+ * TemplateHandler
+ * apiGetQueryParserTemplatesHtml
+ */

 class QueryParserGenerator {
    constructor() {
--- a/ext/bg/js/search-query-parser.js
+++ b/ext/bg/js/search-query-parser.js
@ -16,7 +16,15 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiTermsFind, apiOptionsSet, apiTextParse, apiTextParseMecab, TextScanner, QueryParserGenerator, docSentenceExtract*/
+/* global
+ * QueryParserGenerator
+ * TextScanner
+ * apiOptionsSet
+ * apiTermsFind
+ * apiTextParse
+ * apiTextParseMecab
+ * docSentenceExtract
+ */

 class QueryParser extends TextScanner {
    constructor(search) {
--- a/ext/bg/js/search.js
+++ b/ext/bg/js/search.js
@ -16,7 +16,14 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiOptionsSet, apiTermsFind, apiClipboardGet, Display, QueryParser, ClipboardMonitor*/
+/* global
+ * ClipboardMonitor
+ * Display
+ * QueryParser
+ * apiClipboardGet
+ * apiOptionsSet
+ * apiTermsFind
+ */

 class DisplaySearch extends Display {
    constructor() {
--- a/ext/bg/js/settings/anki-templates.js
+++ b/ext/bg/js/settings/anki-templates.js
@ -16,10 +16,18 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global getOptionsContext, getOptionsMutable, settingsSaveOptions
-ankiGetFieldMarkers, ankiGetFieldMarkersHtml
-apiOptionsGet, apiTermsFind, apiGetDefaultAnkiFieldTemplates, apiTemplateRender
-AnkiNoteBuilder*/
+/* global
+ * AnkiNoteBuilder
+ * ankiGetFieldMarkers
+ * ankiGetFieldMarkersHtml
+ * apiGetDefaultAnkiFieldTemplates
+ * apiOptionsGet
+ * apiTemplateRender
+ * apiTermsFind
+ * getOptionsContext
+ * getOptionsMutable
+ * settingsSaveOptions
+ */

 function onAnkiFieldTemplatesReset(e) {
    e.preventDefault();
--- a/ext/bg/js/settings/anki.js
+++ b/ext/bg/js/settings/anki.js
@ -16,9 +16,16 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global getOptionsContext, getOptionsMutable, settingsSaveOptions
-utilBackgroundIsolate, utilAnkiGetDeckNames, utilAnkiGetModelNames, utilAnkiGetModelFieldNames
-onFormOptionsChanged*/
+/* global
+ * getOptionsContext
+ * getOptionsMutable
+ * onFormOptionsChanged
+ * settingsSaveOptions
+ * utilAnkiGetDeckNames
+ * utilAnkiGetModelFieldNames
+ * utilAnkiGetModelNames
+ * utilBackgroundIsolate
+ */

 // Private

--- a/ext/bg/js/settings/audio.js
+++ b/ext/bg/js/settings/audio.js
@ -16,8 +16,14 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global getOptionsContext, getOptionsMutable, settingsSaveOptions, apiAudioGetUri
-AudioSystem, AudioSourceUI*/
+/* global
+ * AudioSourceUI
+ * AudioSystem
+ * apiAudioGetUri
+ * getOptionsContext
+ * getOptionsMutable
+ * settingsSaveOptions
+ */

 let audioSourceUI = null;
 let audioSystem = null;
--- a/ext/bg/js/settings/backup.js
+++ b/ext/bg/js/settings/backup.js
@ -16,9 +16,17 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiOptionsGetFull, apiGetEnvironmentInfo, apiGetDefaultAnkiFieldTemplates
-utilBackend, utilIsolate, utilBackgroundIsolate, utilReadFileArrayBuffer
-optionsGetDefault, optionsUpdateVersion*/
+/* global
+ * apiGetDefaultAnkiFieldTemplates
+ * apiGetEnvironmentInfo
+ * apiOptionsGetFull
+ * optionsGetDefault
+ * optionsUpdateVersion
+ * utilBackend
+ * utilBackgroundIsolate
+ * utilIsolate
+ * utilReadFileArrayBuffer
+ */

 // Exporting

--- a/ext/bg/js/settings/conditions-ui.js
+++ b/ext/bg/js/settings/conditions-ui.js
@ -16,7 +16,9 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global conditionsNormalizeOptionValue*/
+/* global
+ * conditionsNormalizeOptionValue
+ */

 class ConditionsUI {
    static instantiateTemplate(templateSelector) {
--- a/ext/bg/js/settings/dictionaries.js
+++ b/ext/bg/js/settings/dictionaries.js
@ -16,11 +16,23 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global getOptionsContext, getOptionsMutable, getOptionsFullMutable, settingsSaveOptions, apiOptionsGetFull, apiOptionsGet
-utilBackgroundIsolate, utilDatabaseDeleteDictionary, utilDatabaseGetDictionaryInfo, utilDatabaseGetDictionaryCounts
-utilDatabasePurge, utilDatabaseImport
-storageUpdateStats, storageEstimate
-PageExitPrevention*/
+/* global
+ * PageExitPrevention
+ * apiOptionsGet
+ * apiOptionsGetFull
+ * getOptionsContext
+ * getOptionsFullMutable
+ * getOptionsMutable
+ * settingsSaveOptions
+ * storageEstimate
+ * storageUpdateStats
+ * utilBackgroundIsolate
+ * utilDatabaseDeleteDictionary
+ * utilDatabaseGetDictionaryCounts
+ * utilDatabaseGetDictionaryInfo
+ * utilDatabaseImport
+ * utilDatabasePurge
+ */

 let dictionaryUI = null;

--- a/ext/bg/js/settings/main.js
+++ b/ext/bg/js/settings/main.js
@ -16,12 +16,25 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global getOptionsContext, apiOptionsSave
-utilBackend, utilIsolate, utilBackgroundIsolate
-ankiErrorShown, ankiFieldsToDict
-ankiTemplatesUpdateValue, onAnkiOptionsChanged, onDictionaryOptionsChanged
-appearanceInitialize, audioSettingsInitialize, profileOptionsSetup, dictSettingsInitialize
-ankiInitialize, ankiTemplatesInitialize, storageInfoInitialize, backupInitialize
+/* global
+ * ankiErrorShown
+ * ankiFieldsToDict
+ * ankiInitialize
+ * ankiTemplatesInitialize
+ * ankiTemplatesUpdateValue
+ * apiOptionsSave
+ * appearanceInitialize
+ * audioSettingsInitialize
+ * backupInitialize
+ * dictSettingsInitialize
+ * getOptionsContext
+ * onAnkiOptionsChanged
+ * onDictionaryOptionsChanged
+ * profileOptionsSetup
+ * storageInfoInitialize
+ * utilBackend
+ * utilBackgroundIsolate
+ * utilIsolate
 */

 function getOptionsMutable(optionsContext) {
--- a/ext/bg/js/settings/popup-preview-frame.js
+++ b/ext/bg/js/settings/popup-preview-frame.js
@ -16,7 +16,13 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiOptionsGet, Popup, PopupProxyHost, Frontend, TextSourceRange*/
+/* global
+ * Frontend
+ * Popup
+ * PopupProxyHost
+ * TextSourceRange
+ * apiOptionsGet
+ */

 class SettingsPopupPreview {
    constructor() {
--- a/ext/bg/js/settings/profiles.js
+++ b/ext/bg/js/settings/profiles.js
@ -16,9 +16,17 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global getOptionsMutable, getOptionsFullMutable, settingsSaveOptions, apiOptionsGetFull
-utilBackgroundIsolate, formWrite
-conditionsClearCaches, ConditionsUI, profileConditionsDescriptor*/
+/* global
+ * ConditionsUI
+ * apiOptionsGetFull
+ * conditionsClearCaches
+ * formWrite
+ * getOptionsFullMutable
+ * getOptionsMutable
+ * profileConditionsDescriptor
+ * settingsSaveOptions
+ * utilBackgroundIsolate
+ */

 let currentProfileIndex = 0;
 let profileConditionsContainer = null;
--- a/ext/bg/js/settings/storage.js
+++ b/ext/bg/js/settings/storage.js
@ -16,7 +16,9 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiGetEnvironmentInfo*/
+/* global
+ * apiGetEnvironmentInfo
+ */

 function storageBytesToLabeledString(size) {
    const base = 1000;
--- a/ext/bg/js/translator.js
+++ b/ext/bg/js/translator.js
@ -16,12 +16,28 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global requestJson
-dictTermsMergeBySequence, dictTagBuildSource, dictTermsMergeByGloss, dictTermsSort, dictTagsSort
-dictEnabledSet, dictTermsGroup, dictTermsCompressTags, dictTermsUndupe, dictTagSanitize
-jpDistributeFurigana, jpConvertHalfWidthKanaToFullWidth, jpConvertNumericTofullWidth
-jpConvertAlphabeticToKana, jpHiraganaToKatakana, jpKatakanaToHiragana, jpIsCodePointJapanese
-Database, Deinflector*/
+/* global
+ * Database
+ * Deinflector
+ * dictEnabledSet
+ * dictTagBuildSource
+ * dictTagSanitize
+ * dictTagsSort
+ * dictTermsCompressTags
+ * dictTermsGroup
+ * dictTermsMergeByGloss
+ * dictTermsMergeBySequence
+ * dictTermsSort
+ * dictTermsUndupe
+ * jpConvertAlphabeticToKana
+ * jpConvertHalfWidthKanaToFullWidth
+ * jpConvertNumericTofullWidth
+ * jpDistributeFurigana
+ * jpHiraganaToKatakana
+ * jpIsCodePointJapanese
+ * jpKatakanaToHiragana
+ * requestJson
+ */

 class Translator {
    constructor() {
--- a/ext/fg/js/document.js
+++ b/ext/fg/js/document.js
@ -16,7 +16,11 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global TextSourceElement, TextSourceRange, DOM*/
+/* global
+ * DOM
+ * TextSourceElement
+ * TextSourceRange
+ */

 const REGEX_TRANSPARENT_COLOR = /rgba\s*\([^)]*,\s*0(?:\.0+)?\s*\)/;

--- a/ext/fg/js/float.js
+++ b/ext/fg/js/float.js
@ -16,7 +16,12 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global popupNestedInitialize, apiForward, apiGetMessageToken, Display*/
+/* global
+ * Display
+ * apiForward
+ * apiGetMessageToken
+ * popupNestedInitialize
+ */

 class DisplayFloat extends Display {
    constructor() {
--- a/ext/fg/js/frontend-initialize.js
+++ b/ext/fg/js/frontend-initialize.js
@ -16,7 +16,11 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global PopupProxyHost, PopupProxy, Frontend*/
+/* global
+ * Frontend
+ * PopupProxy
+ * PopupProxyHost
+ */

 async function main() {
    await yomichan.prepare();
--- a/ext/fg/js/frontend.js
+++ b/ext/fg/js/frontend.js
@ -16,7 +16,14 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiGetZoom, apiOptionsGet, apiTermsFind, apiKanjiFind, docSentenceExtract, TextScanner*/
+/* global
+ * TextScanner
+ * apiGetZoom
+ * apiKanjiFind
+ * apiOptionsGet
+ * apiTermsFind
+ * docSentenceExtract
+ */

 class Frontend extends TextScanner {
    constructor(popup, ignoreNodes) {
--- a/ext/fg/js/popup-nested.js
+++ b/ext/fg/js/popup-nested.js
@ -16,7 +16,9 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiOptionsGet*/
+/* global
+ * apiOptionsGet
+ */

 let popupNestedInitialized = false;

--- a/ext/fg/js/popup-proxy-host.js
+++ b/ext/fg/js/popup-proxy-host.js
@ -16,7 +16,11 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiFrameInformationGet, FrontendApiReceiver, Popup*/
+/* global
+ * FrontendApiReceiver
+ * Popup
+ * apiFrameInformationGet
+ */

 class PopupProxyHost {
    constructor() {
--- a/ext/fg/js/popup-proxy.js
+++ b/ext/fg/js/popup-proxy.js
@ -16,7 +16,9 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global FrontendApiSender*/
+/* global
+ * FrontendApiSender
+ */

 class PopupProxy {
    constructor(id, depth, parentId, parentFrameId, url) {
--- a/ext/fg/js/popup.js
+++ b/ext/fg/js/popup.js
@ -16,7 +16,10 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global apiInjectStylesheet, apiGetMessageToken*/
+/* global
+ * apiGetMessageToken
+ * apiInjectStylesheet
+ */

 class Popup {
    constructor(id, depth, frameIdPromise) {
--- a/ext/mixed/js/display-generator.js
+++ b/ext/mixed/js/display-generator.js
@ -16,7 +16,10 @@
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

-/*global apiGetDisplayTemplatesHtml, TemplateHandler*/
+/* global
+ * TemplateHandler
+ * apiGetDisplayTemplatesHtml
+ */

 class DisplayGenerator {
    constructor() {
--- a/ext/mixed/js/display.js
+++ b/ext/mixed/js/display.js
@ -16,10 +16,24 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global docRangeFromPoint, docSentenceExtract
-apiKanjiFind, apiTermsFind, apiNoteView, apiOptionsGet, apiDefinitionsAddable, apiDefinitionAdd
-apiScreenshotGet, apiForward, apiAudioGetUri
-AudioSystem, DisplayGenerator, WindowScroll, DisplayContext, DOM*/
+/* global
+ * AudioSystem
+ * DOM
+ * DisplayContext
+ * DisplayGenerator
+ * WindowScroll
+ * apiAudioGetUri
+ * apiDefinitionAdd
+ * apiDefinitionsAddable
+ * apiForward
+ * apiKanjiFind
+ * apiNoteView
+ * apiOptionsGet
+ * apiScreenshotGet
+ * apiTermsFind
+ * docRangeFromPoint
+ * docSentenceExtract
+ */

 class Display {
    constructor(spinner, container) {
--- a/ext/mixed/js/text-scanner.js
+++ b/ext/mixed/js/text-scanner.js
@ -16,7 +16,11 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/*global docRangeFromPoint, TextSourceRange, DOM*/
+/* global
+ * DOM
+ * TextSourceRange
+ * docRangeFromPoint
+ */

 class TextScanner {
    constructor(node, ignoreNodes, ignoreElements, ignorePoints) {