alex/yomichan
1
Fork 0
Code Releases Activity

Workaround spidermonkey bug so dictionary data loads

Browse Source 
We need to make a copy of the iteration variable in the for-of
loop so that the distinct values are available in the callback.
This commit is contained in:
ispedals 2016-06-18 18:33:51 -04:00
parent b4fe1f1fa6
commit 5e0ac4e8ea
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ext/bg/js/translator.js
View File

@ -46,8 +46,17 @@ class Translator {
const pendingLoads = []; const pendingLoads = [];
for (let key of files) { for (let key of files) {
/*
Spidermonkey does not implement lexical bindings for for-of loop
(see https://bugzilla.mozilla.org/show_bug.cgi?id=449811)
so we need to manually make a new declaration for key.
Otherwise key will always remain the same in the callback to loadData
and the dictionary data will not be set correctly
*/
let key_ = key;
pendingLoads.push(key); pendingLoads.push(key);
Translator.loadData(this.paths[key], (response) => { Translator.loadData(this.paths[key], (response) => {
let key = key_
switch (key) { switch (key) {
case 'rules': case 'rules':
this.deinflector.setRules(JSON.parse(response)); this.deinflector.setRules(JSON.parse(response));