This commit is contained in:
Alex Yatskov 2016-04-07 22:41:16 -07:00
parent edbb8086bc
commit 5db0d5d59a
4 changed files with 24 additions and 11 deletions

View File

@ -20,12 +20,14 @@
function optionsToForm(opts) {
$('#scanLength').val(opts.scanLength);
$('#loadOnStartup').prop('checked', opts.loadOnStartup);
$('#highlightText').prop('checked', opts.highlightText);
}
function formToOptions() {
return sanitizeOptions({
scanLength: $('#scanLength').val(),
loadOnStartup: $('#loadOnStartup').prop('checked')
scanLength: $('#scanLength').val(),
loadOnStartup: $('#loadOnStartup').prop('checked'),
highlightText: $('#highlightText').prop('checked')
});
}

View File

@ -20,7 +20,8 @@
function sanitizeOptions(options) {
const defaults = {
scanLength: 20,
loadOnStartup: false
loadOnStartup: false,
highlightText: true
};
for (const key in defaults) {

View File

@ -21,9 +21,15 @@
<div class="form-group">
<div class="col-sm-offset-2 col-sm-10">
<div class="checkbox">
<label>
<input type="checkbox" id="loadOnStartup"> Load on startup
</label>
<label><input type="checkbox" id="loadOnStartup"> Load on startup</label>
</div>
</div>
</div>
<div class="form-group">
<div class="col-sm-offset-2 col-sm-10">
<div class="checkbox">
<label><input type="checkbox" id="highlightText" checked> Highlight text</label>
</div>
</div>
</div>

View File

@ -113,9 +113,11 @@ class Client {
}
showPopup(range) {
const selection = window.getSelection();
selection.removeAllRanges();
selection.addRange(range);
if (this.options.highlightText) {
const selection = window.getSelection();
selection.removeAllRanges();
selection.addRange(range);
}
const pos = getPopupPositionForRange(this.popup, range, this.popupOffset);
@ -130,8 +132,10 @@ class Client {
return;
}
const selection = window.getSelection();
selection.removeAllRanges();
if (this.options.highlightText) {
const selection = window.getSelection();
selection.removeAllRanges();
}
this.popupText = '';
this.popup.style.visibility = 'hidden';