alex/yomichan
1
Fork 0
Code Releases Activity

CssStyleApplier updates (#1784)

Browse Source 
* Remove debug log

* Remove style attribute if empty

* Remove data-* attributes
This commit is contained in:
toasted-nutbread 2021-07-02 18:28:29 -04:00 committed by GitHub
parent 0c00c56e39
commit 56b2462f13
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ext/js/dom/css-style-applier.js
View File

@ -57,9 +57,6 @@ class CssStyleApplier {
const {className} = element; const {className} = element;
if (className.length === 0) { continue; } if (className.length === 0) { continue; }
let cssTextNew = ''; let cssTextNew = '';
if (className.indexOf('th') >= 0) {
console.log(className, this._getRulesForClass(className));
}
for (const {selectorText, styles} of this._getRulesForClass(className)) { for (const {selectorText, styles} of this._getRulesForClass(className)) {
if (!element.matches(selectorText)) { continue; } if (!element.matches(selectorText)) { continue; }
cssTextNew += this._getCssText(styles); cssTextNew += this._getCssText(styles);
@ -69,7 +66,17 @@ class CssStyleApplier {
} }
for (const {element, style} of elementStyles) { for (const {element, style} of elementStyles) {
element.removeAttribute('class'); element.removeAttribute('class');
element.setAttribute('style', style); if (style.length > 0) {
element.setAttribute('style', style);
} else {
element.removeAttribute('style');
}
}
for (const element of elements) {
const {dataset} = element;
for (const key of Object.keys(dataset)) {
delete dataset[key];
}
} }
} }