alex/yomichan
1
Fork 0
Code Releases Activity

Fix docRangeFromPoint sometimes not returning results

Browse Source 
If range.getClientRects() has more than 1 result, it is possible that nothing will be returned even when hovering over a valid target.
This commit is contained in:
toasted-nutbread 2019-06-22 21:42:35 -04:00
parent f77ac32fe1
commit 542cdb2df9
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ext/fg/js/document.js
View File

@ -97,20 +97,12 @@ function docRangeFromPoint(point) {
if(imposter !== null) imposter.style.zIndex = -2147483646; if(imposter !== null) imposter.style.zIndex = -2147483646;
const rects = range.getClientRects(); const rects = range.getClientRects();
for (const rect of rects) {
if (rects.length === 0) { if (point.y <= rect.bottom + 2) {
return;
}
const rect = rects[0];
if (point.y > rect.bottom + 2) {
return;
}
if (range) {
return new TextSourceRange(range); return new TextSourceRange(range);
} }
} }
}
function docSentenceExtract(source, extent) { function docSentenceExtract(source, extent) {
const quotesFwd = {'「': '」', '『': '』', "'": "'", '"': '"'}; const quotesFwd = {'「': '」', '『': '』', "'": "'", '"': '"'};