alex/yomichan
1
Fork 0
Code Releases Activity

Fix search tags in split and grouped display modes (#1412)

Browse Source
This commit is contained in:
toasted-nutbread 2021-02-16 21:19:52 -05:00 committed by GitHub
parent 6fc5eb2ae1
commit 53d02ca3d3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ext/css/display.css
View File

@ -973,6 +973,9 @@ button.action-button[data-icon=source-term]::before {
bottom: -0.5em; bottom: -0.5em;
white-space: nowrap; white-space: nowrap;
} }
.entry[data-type=term][data-expression-multi=true] .term-tags>.tag[data-category=search] {
display: none;
}
/* Definitions */ /* Definitions */

11
ext/js/display/display-generator.js
View File

@ -70,7 +70,8 @@ class DisplayGenerator {
const uniqueExpressions = new Set(); const uniqueExpressions = new Set();
const uniqueReadings = new Set(); const uniqueReadings = new Set();
for (const {expression, reading} of expressions) { for (let {expression, reading} of expressions) {
if (reading.length === 0) { reading = expression; }
uniqueExpressions.add(expression); uniqueExpressions.add(expression);
uniqueReadings.add(reading); uniqueReadings.add(reading);
} }
@ -92,6 +93,14 @@ class DisplayGenerator {
this._appendMultiple(pitchesContainer, this._createPitches.bind(this), pitches); this._appendMultiple(pitchesContainer, this._createPitches.bind(this), pitches);
this._appendMultiple(termTagsContainer, this._createTermTag.bind(this), termTags, expressions.length); this._appendMultiple(termTagsContainer, this._createTermTag.bind(this), termTags, expressions.length);
for (const expression of uniqueExpressions) {
termTagsContainer.appendChild(this._createSearchTag(expression));
}
for (const reading of uniqueReadings) {
if (uniqueExpressions.has(reading)) { continue; }
termTagsContainer.appendChild(this._createSearchTag(reading));
}
// Add definitions // Add definitions
const dictionaryTag = this._createDictionaryTag(null); const dictionaryTag = this._createDictionaryTag(null);
for (let i = 0, ii = definitions.length; i < ii; ++i) { for (let i = 0, ii = definitions.length; i < ii; ++i) {