alex/yomichan
1
Fork 0
Code Releases Activity

Don't use innerHTML

Browse Source
This commit is contained in:
toasted-nutbread 2020-02-23 11:49:52 -05:00
parent f463e2e238
commit 53220af68e
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ext/bg/js/search-query-parser.js
View File

@ -164,7 +164,7 @@ class QueryParser extends TextScanner {
} }
renderParserSelect() { renderParserSelect() {
this.queryParserSelect.innerHTML = ''; this.queryParserSelect.textContent = '';
if (this.parseResults.length > 1) { if (this.parseResults.length > 1) {
const select = this.queryParserGenerator.createParserSelect(this.parseResults, this.selectedParser); const select = this.queryParserGenerator.createParserSelect(this.parseResults, this.selectedParser);
select.addEventListener('change', this.onParserChange.bind(this)); select.addEventListener('change', this.onParserChange.bind(this));

2
ext/fg/js/source.js
View File

@ -366,7 +366,7 @@ class TextSourceElement {
setEndOffset(length) { setEndOffset(length) {
switch (this.element.nodeName.toUpperCase()) { switch (this.element.nodeName.toUpperCase()) {
case 'BUTTON': case 'BUTTON':
this.content = this.element.innerHTML; this.content = this.element.textContent;
break; break;
case 'IMG': case 'IMG':
this.content = this.element.getAttribute('alt'); this.content = this.element.getAttribute('alt');