Translator alphanumeric improvement (#1635)

* Simplify alphanumeric check

* Update option name for clarity

ext/js/background/backend.js

@@ -1896,7 +1896,7 @@ class Backend {
         return {
             wildcard,
             mainDictionary,
-            alphanumeric,
+            removeNonJapaneseCharacters: !alphanumeric,
             convertHalfWidthCharacters,
             convertNumericCharacters,
             convertAlphabeticCharacters,

ext/js/language/translator.js

@@ -64,7 +64,7 @@ class Translator {
      *   {
      *     wildcard: (enum: null, 'prefix', 'suffix'),
      *     mainDictionary: (string),
-     *     alphanumeric: (boolean),
+     *     removeNonJapaneseCharacters: (boolean),
      *     convertHalfWidthCharacters: (enum: 'false', 'true', 'variant'),
      *     convertNumericCharacters: (enum: 'false', 'true', 'variant'),
      *     convertAlphabeticCharacters: (enum: 'false', 'true', 'variant'),
@@ -169,8 +169,10 @@ class Translator {
     // Find terms internal implementation
 
     async _findTermsInternal(text, enabledDictionaryMap, options) {
-        const {alphanumeric, wildcard} = options;
+        const {wildcard} = options;
-        text = this._getSearchableText(text, alphanumeric);
+        if (options.removeNonJapaneseCharacters) {
+            text = this._getJapaneseOnlyText(text);
+        }
         if (text.length === 0) {
             return {dictionaryEntries: [], originalTextLength: 0};
         }
@@ -302,15 +304,16 @@ class Translator {
         return text;
     }
 
-    _getSearchableText(text, allowAlphanumericCharacters) {
+    _getJapaneseOnlyText(text) {
-        if (allowAlphanumericCharacters) { return text; }
         const jp = this._japaneseUtil;
         let length = 0;
         for (const c of text) {
-            if (!jp.isCodePointJapanese(c.codePointAt(0))) { break; }
+            if (!jp.isCodePointJapanese(c.codePointAt(0))) {
+                return text.substring(0, length);
+            }
             length += c.length;
         }
-        return length >= text.length ? text : text.substring(0, length);
+        return text;
     }
 
     _getTextOptionEntryVariants(value) {

test/data/translator-test-inputs.json

@@ -14,7 +14,7 @@
         "default": {
             "wildcard": null,
             "mainDictionary": "${title}",
-            "alphanumeric": false,
+            "removeNonJapaneseCharacters": true,
             "convertHalfWidthCharacters": false,
             "convertNumericCharacters": false,
             "convertAlphabeticCharacters": false,
@@ -182,7 +182,7 @@
             "options": [
                 "default",
                 {
-                    "alphanumeric": true,
+                    "removeNonJapaneseCharacters": false,
                     "textReplacements": [
                         null,
                         [
@@ -204,7 +204,7 @@
             "options": [
                 "default",
                 {
-                    "alphanumeric": true,
+                    "removeNonJapaneseCharacters": false,
                     "textReplacements": [
                         null,
                         [
@@ -226,7 +226,7 @@
             "options": [
                 "default",
                 {
-                    "alphanumeric": true,
+                    "removeNonJapaneseCharacters": false,
                     "textReplacements": [
                         null,
                         [
@@ -248,7 +248,7 @@
             "options": [
                 "default",
                 {
-                    "alphanumeric": true,
+                    "removeNonJapaneseCharacters": false,
                     "textReplacements": [
                         null,
                         [
@@ -270,7 +270,7 @@
             "options": [
                 "default",
                 {
-                    "alphanumeric": true,
+                    "removeNonJapaneseCharacters": false,
                     "textReplacements": [
                         null,
                         [