alex/yomichan
1
Fork 0
Code Releases Activity

support for audio volume adjustment (fixes #39)

Browse Source
This commit is contained in:
Alex Yatskov 2017-04-01 12:01:34 -07:00
parent f556c95038
commit 4de9e5e9e0
4 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ext/bg/js/options.js
View File

@ -26,6 +26,7 @@ function formRead() {
const optionsNew = $.extend(true, {}, optionsOld); const optionsNew = $.extend(true, {}, optionsOld);
optionsNew.general.audioPlayback = $('#audio-playback-buttons').prop('checked'); optionsNew.general.audioPlayback = $('#audio-playback-buttons').prop('checked');
optionsNew.general.audioVolume = $('#audio-playback-volume').val();
optionsNew.general.groupResults = $('#group-terms-results').prop('checked'); optionsNew.general.groupResults = $('#group-terms-results').prop('checked');
optionsNew.general.softKatakana = $('#soft-katakana-search').prop('checked'); optionsNew.general.softKatakana = $('#soft-katakana-search').prop('checked');
optionsNew.general.showAdvanced = $('#show-advanced-options').prop('checked'); optionsNew.general.showAdvanced = $('#show-advanced-options').prop('checked');
@ -111,6 +112,7 @@ $(document).ready(() => {
optionsLoad().then(options => { optionsLoad().then(options => {
$('#audio-playback-buttons').prop('checked', options.general.audioPlayback); $('#audio-playback-buttons').prop('checked', options.general.audioPlayback);
$('#audio-playback-volume').val(options.general.audioVolume);
$('#group-terms-results').prop('checked', options.general.groupResults); $('#group-terms-results').prop('checked', options.general.groupResults);
$('#soft-katakana-search').prop('checked', options.general.softKatakana); $('#soft-katakana-search').prop('checked', options.general.softKatakana);
$('#show-advanced-options').prop('checked', options.general.showAdvanced); $('#show-advanced-options').prop('checked', options.general.showAdvanced);

1
ext/bg/js/util.js
View File

@ -85,6 +85,7 @@ function optionsSetDefaults(options) {
general: { general: {
enable: true, enable: true,
audioPlayback: true, audioPlayback: true,
audioVolume: 100,
groupResults: true, groupResults: true,
softKatakana: true, softKatakana: true,
maxResults: 32, maxResults: 32,

13
ext/bg/options.html
View File

@ -25,10 +25,6 @@
<div> <div>
<h3>General Options</h3> <h3>General Options</h3>
<div class="checkbox">
<label><input type="checkbox" id="audio-playback-buttons"> Audio playback buttons</label>
</div>
<div class="checkbox"> <div class="checkbox">
<label><input type="checkbox" id="group-terms-results"> Group term results</label> <label><input type="checkbox" id="group-terms-results"> Group term results</label>
</div> </div>
@ -41,6 +37,15 @@
<label><input type="checkbox" id="soft-katakana-search"> Soft Katakana search</label> <label><input type="checkbox" id="soft-katakana-search"> Soft Katakana search</label>
</div> </div>
<div class="checkbox">
<label><input type="checkbox" id="audio-playback-buttons"> Audio playback buttons</label>
</div>
<div class="form-group options-advanced">
<label for="audio-playback-volume">Audio playback volume (percent)</label>
<input type="number" min="0" max="100" id="audio-playback-volume" class="form-control">
</div>
<div class="form-group options-advanced"> <div class="form-group options-advanced">
<label for="max-displayed-results">Maximum displayed results</label> <label for="max-displayed-results">Maximum displayed results</label>
<input type="number" min="1" id="max-displayed-results" class="form-control"> <input type="number" min="1" id="max-displayed-results" class="form-control">

2
ext/mixed/js/display.js
View File

@ -343,6 +343,7 @@ class Display {
let audio = this.audioCache[url]; let audio = this.audioCache[url];
if (audio) { if (audio) {
audio.currentTime = 0; audio.currentTime = 0;
audio.volume = this.options.general.audioVolume / 100.0;
audio.play(); audio.play();
} else { } else {
audio = new Audio(url); audio = new Audio(url);
@ -352,6 +353,7 @@ class Display {
} }
this.audioCache[url] = audio; this.audioCache[url] = audio;
audio.volume = this.options.general.audioVolume / 100.0;
audio.play(); audio.play();
}; };
} }