alex/yomichan
1
Fork 0
Code Releases Activity

Handle error if _waitForFrontendReady fails when creating a popup proxy (#760)

Browse Source
This commit is contained in:
toasted-nutbread 2020-09-04 17:55:25 -04:00 committed by GitHub
parent d8f488e28c
commit 4cd1676ddc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ext/fg/js/frontend.js
View File

@ -357,7 +357,12 @@ class Frontend {
async _getIframeProxyPopup() { async _getIframeProxyPopup() {
const targetFrameId = 0; // Root frameId const targetFrameId = 0; // Root frameId
await this._waitForFrontendReady(targetFrameId); try {
await this._waitForFrontendReady(targetFrameId);
} catch (e) {
// Root frame not available
return await this._getDefaultPopup();
}
const {popupId} = await api.crossFrame.invoke(targetFrameId, 'getPopupInfo'); const {popupId} = await api.crossFrame.invoke(targetFrameId, 'getPopupInfo');
if (popupId === null) { if (popupId === null) {