alex/yomichan
1
Fork 0
Code Releases Activity

Translator frequency data improvements (#1184)

Browse Source 
* Specify if a frequency has a specific reading

* Make frequency data creation more standardized

* Update test data
This commit is contained in:
toasted-nutbread 2020-12-30 15:12:08 -05:00 committed by GitHub
parent 0f3b9ec7fc
commit 4650f0b542
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 689 additions and 345 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ext/bg/js/translator.js
View File

@ -706,7 +706,7 @@ class Translator {
switch (mode) { switch (mode) {
case 'freq': case 'freq':
{ {
const frequencyData = this._getFrequencyData(expression, reading, dictionary, data); const frequencyData = this._getTermFrequencyData(expression, reading, dictionary, data);
if (frequencyData === null) { continue; } if (frequencyData === null) { continue; }
for (const {frequencies} of targets) { frequencies.push(frequencyData); } for (const {frequencies} of targets) { frequencies.push(frequencyData); }
} }
@ -733,7 +733,10 @@ class Translator {
for (const {character, mode, data, dictionary, index} of metas) { for (const {character, mode, data, dictionary, index} of metas) {
switch (mode) { switch (mode) {
case 'freq': case 'freq':
definitions[index].frequencies.push({character, frequency: data, dictionary}); {
const frequencyData = this._getKanjiFrequencyData(character, dictionary, data);
definitions[index].frequencies.push(frequencyData);
}
break; break;
} }
} }
@ -805,13 +808,18 @@ class Translator {
return tagMetaList; return tagMetaList;
} }
_getFrequencyData(expression, reading, dictionary, data) { _getTermFrequencyData(expression, reading, dictionary, data) {
let frequency = data; let frequency = data;
if (data !== null && typeof data === 'object') { const hasReading = (data !== null && typeof data === 'object');
if (hasReading) {
if (data.reading !== reading) { return null; } if (data.reading !== reading) { return null; }
frequency = data.frequency; frequency = data.frequency;
} }
return {expression, reading, dictionary, frequency}; return {dictionary, expression, reading, hasReading, frequency};
}
_getKanjiFrequencyData(character, dictionary, data) {
return {dictionary, character, frequency: data};
} }
async _getPitchData(expression, reading, dictionary, data) { async _getPitchData(expression, reading, dictionary, data) {

1016
test/data/test-translator-data.json
View File

File diff suppressed because it is too large Load Diff