alex/yomichan
1
Fork 0
Code Releases Activity

Fix search box resizing (#1316)

Browse Source 
* Don't resize the search box unless it's necessary

* Allow search box to shrink under certain circumstances
This commit is contained in:
toasted-nutbread 2021-01-25 22:19:44 -05:00 committed by GitHub
parent 34fed22ccb
commit 43c9a5eb6a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ext/bg/js/search.js
View File

@ -149,13 +149,15 @@ class DisplaySearch extends Display {
if (typeof source !== 'string') { source = ''; } if (typeof source !== 'string') { source = ''; }
this._queryInput.value = source; if (this._queryInput.value !== source) {
this._updateSearchHeight(); this._queryInput.value = source;
this._updateSearchHeight(true);
}
this._setIntroVisible(!valid, animate); this._setIntroVisible(!valid, animate);
} }
_onSearchInput() { _onSearchInput() {
this._updateSearchHeight(); this._updateSearchHeight(false);
} }
_onSearchKeydown(e) { _onSearchKeydown(e) {
@ -185,6 +187,7 @@ class DisplaySearch extends Display {
text = text.substring(0, maximumClipboardSearchLength); text = text.substring(0, maximumClipboardSearchLength);
} }
this._queryInput.value = text; this._queryInput.value = text;
this._updateSearchHeight(true);
this._search(animate, false, autoSearchClipboardContent); this._search(animate, false, autoSearchClipboardContent);
} }
@ -357,11 +360,14 @@ class DisplaySearch extends Display {
this.setContent(details); this.setContent(details);
} }
_updateSearchHeight() { _updateSearchHeight(shrink) {
const node = this._queryInput; const node = this._queryInput;
if (shrink) {
node.style.height = '0';
}
const {scrollHeight} = node; const {scrollHeight} = node;
const currentHeight = node.getBoundingClientRect().height; const currentHeight = node.getBoundingClientRect().height;
if (scrollHeight >= currentHeight - 1) { if (shrink || scrollHeight >= currentHeight - 1) {
node.style.height = `${scrollHeight}px`; node.style.height = `${scrollHeight}px`;
} }
} }