alex/yomichan
1
Fork 0
Code Releases Activity

Improve what info is logged when debugging a definition (#1756)

Browse Source
This commit is contained in:
toasted-nutbread 2021-06-26 14:10:18 -04:00 committed by GitHub
parent 845070b817
commit 435af3a485
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
ext/js/display/display.js
View File

@ -1073,7 +1073,7 @@ class Display extends EventDispatcher {
try { try {
this._updateAdderButtonsPromise = promise; this._updateAdderButtonsPromise = promise;
const modes = isTerms ? ['term-kanji', 'term-kana'] : ['kanji']; const modes = this._getModes(isTerms);
let states; let states;
try { try {
const noteContext = this._getNoteContext(); const noteContext = this._getNoteContext();
@ -1922,9 +1922,16 @@ class Display extends EventDispatcher {
return typeof queryPostProcessor === 'function' ? queryPostProcessor(query) : query; return typeof queryPostProcessor === 'function' ? queryPostProcessor(query) : query;
} }
_getModes(isTerms) {
return isTerms ? ['term-kanji', 'term-kana'] : ['kanji'];
}
async _logDictionaryEntryData(index) { async _logDictionaryEntryData(index) {
if (index < 0 || index >= this._dictionaryEntries.length) { return; } if (index < 0 || index >= this._dictionaryEntries.length) { return; }
const dictionaryEntry = this._dictionaryEntries[index]; const dictionaryEntry = this._dictionaryEntries[index];
const result = {dictionaryEntry};
// Anki note data
let ankiNoteData; let ankiNoteData;
let ankiNoteDataException; let ankiNoteDataException;
try { try {
@ -1943,10 +1950,32 @@ class Display extends EventDispatcher {
} catch (e) { } catch (e) {
ankiNoteDataException = e; ankiNoteDataException = e;
} }
const result = {dictionaryEntry, ankiNoteData}; result.ankiNoteData = ankiNoteData;
if (typeof ankiNoteDataException !== 'undefined') { if (typeof ankiNoteDataException !== 'undefined') {
result.ankiNoteDataException = ankiNoteDataException; result.ankiNoteDataException = ankiNoteDataException;
} }
// Anki notes
const ankiNotes = [];
const modes = this._getModes(dictionaryEntry.type === 'term');
for (const mode of modes) {
let ankiNote;
let ankiNoteException;
const ankiNoteErrors = [];
try {
const noteContext = this._getNoteContext();
ankiNote = await this._createNote(dictionaryEntry, mode, noteContext, false, ankiNoteErrors);
} catch (e) {
ankiNoteException = e;
}
const entry = {mode, ankiNote};
if (typeof ankiNoteException !== 'undefined') {
entry.ankiNoteException = ankiNoteException;
}
ankiNotes.push(entry);
}
result.ankiNotes = ankiNotes;
console.log(result); console.log(result);
} }
} }